Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 11567011: Conditionally call SchedulePaint() when activating and deactivating inactive rendering (Closed)

Created:
8 years ago by pkotwicz
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Conditionally call SchedulePaint() when activating and deactivating inactive rendering. BUG=160905 Test=Manual - crbug.com/165841 does not occur (Omitting the step to remove SchedulePaint from the code) - Bug described in http://codereview.chromium.org/8386064 does not occur Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173589

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M ui/views/widget/native_widget_win.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M ui/views/widget/widget.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/window/non_client_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
sky@ can you please take a look? I checked and http://codereview.chromium.org/8386064does not occur with this ...
8 years ago (2012-12-13 15:40:51 UTC) #1
sky
Did you try with classic (no aero)?
8 years ago (2012-12-13 19:20:39 UTC) #2
pkotwicz
Yes. This CL does not change the behavior as I always end calling SchedulePaint() upon ...
8 years ago (2012-12-13 20:39:11 UTC) #3
sky
LGTM
8 years ago (2012-12-13 22:50:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11567011/2001
8 years ago (2012-12-17 19:47:41 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-18 00:20:58 UTC) #6
Message was sent while issue was closed.
Change committed as 173589

Powered by Google App Engine
This is Rietveld 408576698