Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 11567003: Adding a new folder/url to the BMB via right-click insert it at the location clicked (Closed)

Created:
8 years ago by yoichio
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org, yosin_UTC9
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adding a new folder/url to the BMB via right-click insert it at the location clicked BUG=82610 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173431

Patch Set 1 #

Patch Set 2 : update unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M chrome/browser/bookmarks/bookmark_utils.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yoichio
8 years ago (2012-12-13 05:38:37 UTC) #1
sky
Can't you also get here if the user clicks the 'new folder' button in the ...
8 years ago (2012-12-13 19:13:54 UTC) #2
yoichio
On 2012/12/13 19:13:54, sky wrote: > Can't you also get here if the user clicks ...
8 years ago (2012-12-14 02:14:50 UTC) #3
yoichio
8 years ago (2012-12-14 02:15:27 UTC) #4
sky
LGTM - how about some test coverage?
8 years ago (2012-12-14 16:46:48 UTC) #5
yoichio
Updates tests. Thank you.
8 years ago (2012-12-17 07:09:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/11567003/6001
8 years ago (2012-12-17 07:09:58 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-17 09:03:35 UTC) #8
Message was sent while issue was closed.
Change committed as 173431

Powered by Google App Engine
This is Rietveld 408576698