Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: presubmit_canned_checks.py

Issue 11566014: Revert 171153 to add a presubmit check to check for closed issues. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
===================================================================
--- presubmit_canned_checks.py (revision 172883)
+++ presubmit_canned_checks.py (working copy)
@@ -799,21 +799,6 @@
issue=int(issue), messages=messages)
-def CheckIssueNotClosed(input_api, output_api):
- """Verifies issue is not closed.
-
- We should not be working with a closed review. CQ and dcommit set this bit,
- so it is a pretty good indicator of whether an issue has been committed.
- """
- issue_props = _GetRietveldIssueProps(input_api=input_api, messages=False)
- if issue_props and issue_props['closed']:
- return [output_api.PresubmitError(
- 'Issue %s is closed. You can reset the issue number associated with\n'
- 'this branch with: git cl issue 0\n' % issue_props['issue']
- )]
- return []
-
-
def _RietveldOwnerAndReviewers(input_api, email_regexp, approval_needed=False):
"""Return the owner and reviewers of a change, if any.
@@ -962,10 +947,6 @@
results.extend(input_api.canned_checks.CheckOwners(
input_api, output_api, source_file_filter=None))
- snapshot("checking review not closed")
- results.extend(input_api.canned_checks.CheckIssueNotClosed(
- input_api, output_api))
-
snapshot("checking long lines")
results.extend(input_api.canned_checks.CheckLongLines(
input_api, output_api, source_file_filter=sources))
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698