Revert 171153 to add a presubmit check to check for closed issues.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 781 matching lines @@
 
 
 def _GetRietveldIssueProps(input_api, messages):
   """Gets the issue properties from rietveld."""
   issue = input_api.change.issue
   if issue and input_api.rietveld:
     return input_api.rietveld.get_issue_properties(
         issue=int(issue), messages=messages)
 
 
-def CheckIssueNotClosed(input_api, output_api):
-  """Verifies issue is not closed.
-
-  We should not be working with a closed review. CQ and dcommit set this bit,
-  so it is a pretty good indicator of whether an issue has been committed.
-  """
-  issue_props = _GetRietveldIssueProps(input_api=input_api, messages=False)
-  if issue_props and issue_props['closed']:
-    return [output_api.PresubmitError(
-        'Issue %s is closed.  You can reset the issue number associated with\n'
-        'this branch with: git cl issue 0\n' % issue_props['issue']
-        )]
-  return []
-
-
 def _RietveldOwnerAndReviewers(input_api, email_regexp, approval_needed=False):
   """Return the owner and reviewers of a change, if any.
 
   If approval_needed is True, only reviewers who have approved the change
   will be returned.
   """
   issue_props = _GetRietveldIssueProps(input_api, True)
   if not issue_props:
     return None, None
 
@@ skipping 128 matching lines @@
       delta_ms = int(1000*(dt2 - snapshot_memory[0]))
       if delta_ms > 500:
         print "  %s took a long time: %dms" % (snapshot_memory[1], delta_ms)
     snapshot_memory[:] = (dt2, msg)
 
   if owners_check:
     snapshot("checking owners")
     results.extend(input_api.canned_checks.CheckOwners(
         input_api, output_api, source_file_filter=None))
 
-  snapshot("checking review not closed")
-  results.extend(input_api.canned_checks.CheckIssueNotClosed(
-      input_api, output_api))
-
   snapshot("checking long lines")
   results.extend(input_api.canned_checks.CheckLongLines(
       input_api, output_api, source_file_filter=sources))
   snapshot( "checking tabs")
   results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
       input_api, output_api, source_file_filter=sources))
   snapshot( "checking stray whitespace")
   results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
       input_api, output_api, source_file_filter=sources))
   snapshot("checking nsobjects")
@@ skipping 21 matching lines @@
     snapshot("checking description")
     results.extend(input_api.canned_checks.CheckChangeHasDescription(
         input_api, output_api))
     results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription(
         input_api, output_api))
     snapshot("checking do not submit in files")
     results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles(
         input_api, output_api))
   snapshot("done")
   return results