Issue 11565053: Allow leading underscore on identifier names in IDL parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11565053: Allow leading underscore on identifier names in IDL parser (Closed)

Created:
8 years ago by asargent_no_longer_on_chrome

Modified:
8 years ago

Reviewers:
noelallen1

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Allow leading underscore on identifier names in IDL parser This lets us have identifiers that match reserved words. BUG=166268 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173332

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -3 lines)			Patch
M	ppapi/generators/idl_lexer.py	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	tools/json_schema_compiler/idl_schema_test.py	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	tools/json_schema_compiler/test/idl_reserved_words.idl	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/11565053/2001

8 years ago (2012-12-15 00:29:00 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests

8 years ago (2012-12-15 05:21:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/11565053/2001

8 years ago (2012-12-15 19:44:38 UTC) #5

Message was sent while issue was closed.

Change committed as 173332