Crash ppapi processes on Windows when calling exit(), _exit(), abort() and ExitProcess()

- crash when calling abort() in all ppapi processes;
- crash when calling exit(), _exit() and ExitProcess() in Pepper Flash process.

BUG=None
TEST=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173362

[yzshen1, 2012-12-14 01:46:08]

Hi, Eric and Brett.

Would you please take a look?

To stay on the safe side, I only turn it on for Pepper Flash, not all ppapi
processes.

Thanks!

[eroman, 2012-12-14 02:03:57]

lgtm

https://codereview.chromium.org/11565026/diff/1/content/ppapi_plugin/ppapi_th...
File content/ppapi_plugin/ppapi_thread.cc (right):

https://codereview.chromium.org/11565026/diff/1/content/ppapi_plugin/ppapi_th...
content/ppapi_plugin/ppapi_thread.cc:285:
base::win::SetAbortBehaviorForCrashReporting();
I suggest enabling this line for all ppapi, not just flash (it should be fairly
safe to do, as it merely changes abort() to generate crashes; exit() will remain
unchanged).

[brettw, 2012-12-14 05:10:06]

lgtm

https://codereview.chromium.org/11565026/diff/1/content/ppapi_plugin/ppapi_th...
File content/ppapi_plugin/ppapi_thread.cc (right):

https://codereview.chromium.org/11565026/diff/1/content/ppapi_plugin/ppapi_th...
content/ppapi_plugin/ppapi_thread.cc:285:
base::win::SetAbortBehaviorForCrashReporting();
Yeah, we should be OK to enable this for all native plugins.

[yzshen1, 2012-12-14 18:19:31]

Thanks!

https://codereview.chromium.org/11565026/diff/1/content/ppapi_plugin/ppapi_th...
File content/ppapi_plugin/ppapi_thread.cc (right):

https://codereview.chromium.org/11565026/diff/1/content/ppapi_plugin/ppapi_th...
content/ppapi_plugin/ppapi_thread.cc:285:
base::win::SetAbortBehaviorForCrashReporting();
On 2012/12/14 05:10:06, brettw wrote:
> Yeah, we should be OK to enable this for all native plugins.

Done.

[commit-bot: I haz the power, 2012-12-15 07:22:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/11565026/2003

[commit-bot: I haz the power, 2012-12-15 12:39:08]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-16 03:20:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/11565026/2003

[commit-bot: I haz the power, 2012-12-16 04:43:07]

Change committed as 173362