Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11565019: Consolidate dialog style flags and strings; etc. (Closed)

Created:
8 years ago by msw
Modified:
8 years ago
Reviewers:
Mike Wittman, sky
CC:
chromium-reviews, darin-cc_chromium.org, Ben Goodger (Google), sail, Albert Bodenhamer, tfarina, whywhat, jam, oshima
Visibility:
Public.

Description

Consolidate dialog style flags and strings; etc. Nix kEnableChromeStyleDialogs and kAuraGoogleDialogFrames. Replace with new ui/base switch kEnableNewDialogStyle. Consolidate strings, nix helper function, cleanup switches. Copy flag to renderer processes in RenderProcessHostImpl. Remove duplicate kEnableTouchDragDrop flag copy code. Replace ModalBackgroundView with a View and SolidBackground. BUG=166075 TEST=--enable-new-dialog-style replaces --enable-chrome-style-dialogs and --aura-google-dialog-frames R=sky@chromium.org,wittman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173521

Patch Set 1 #

Patch Set 2 : Consolidate kAuraGoogleDialogFrames with kEnableNewDialogStyle. #

Patch Set 3 : Fix ash namespace; nix ModalBackgroundView; cleanup switches. #

Patch Set 4 : Alphabetize IDS strings. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -108 lines) Patch
M ash/ash_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 2 4 chunks +6 lines, -29 lines 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 3 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +0 lines, -9 lines 2 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M ui/base/ui_base_switches.cc View 1 2 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
msw
Hey Mike and Scott, please take a look; thanks!
8 years ago (2012-12-14 02:08:03 UTC) #1
sky
LGTM
8 years ago (2012-12-14 16:45:24 UTC) #2
Mike Wittman
https://codereview.chromium.org/11565019/diff/12001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (left): https://codereview.chromium.org/11565019/diff/12001/chrome/common/chrome_switches.h#oldcode475 chrome/common/chrome_switches.h:475: bool UseChromeStyleDialogs(); Has the Mac code been updated to ...
8 years ago (2012-12-14 17:21:17 UTC) #3
msw
https://codereview.chromium.org/11565019/diff/12001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (left): https://codereview.chromium.org/11565019/diff/12001/chrome/common/chrome_switches.h#oldcode475 chrome/common/chrome_switches.h:475: bool UseChromeStyleDialogs(); On 2012/12/14 17:21:18, Mike Wittman wrote: > ...
8 years ago (2012-12-14 18:45:48 UTC) #4
Mike Wittman
On 2012/12/14 18:45:48, msw wrote: > https://codereview.chromium.org/11565019/diff/12001/chrome/common/chrome_switches.h > File chrome/common/chrome_switches.h (left): > > https://codereview.chromium.org/11565019/diff/12001/chrome/common/chrome_switches.h#oldcode475 > ...
8 years ago (2012-12-14 18:52:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11565019/12001
8 years ago (2012-12-14 19:25:51 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-14 23:29:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11565019/12001
8 years ago (2012-12-17 18:39:53 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-17 20:16:20 UTC) #9
Message was sent while issue was closed. 
Change committed as 173521

Powered by Google App Engine
This is Rietveld 408576698