Add ARM support to tools/grokdump.py

Add ARM support to tools/grokdump.py

R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=13319

[ulan, 2013-01-03 16:13:34]

Please take a look.

[Sven Panne, 2013-01-04 07:44:19]

https://codereview.chromium.org/11565014/diff/4001/tools/disasm.py
File tools/disasm.py (right):

https://codereview.chromium.org/11565014/diff/4001/tools/disasm.py#newcode71
tools/disasm.py:71: OBJDUMP_BIN, ' '.join(_COMMON_DISASM_OPTIONS),
Shouldn't we use arch_flags and objdump_flags here, too? And my do we use -d
instead of -D here and no -b binary? My gut feeling is that the objdump
arguments should be in sync (apart from the obvious differences regarding what
to dump). If this is not the case, we definitely need a comment here.

[ulan_google, 2013-01-04 10:12:24]

https://codereview.chromium.org/11565014/diff/4001/tools/disasm.py
File tools/disasm.py (right):

https://codereview.chromium.org/11565014/diff/4001/tools/disasm.py#newcode71
tools/disasm.py:71: OBJDUMP_BIN, ' '.join(_COMMON_DISASM_OPTIONS),
On 2013/01/04 07:44:19, Sven Panne wrote:
> Shouldn't we use arch_flags and objdump_flags here, too? And my do we use -d
> instead of -D here and no -b binary? My gut feeling is that the objdump
> arguments should be in sync (apart from the obvious differences regarding what
> to dump). If this is not the case, we definitely need a comment here.

Done. I added arch_flags to both cases. As discussed offline, the -d, -D, -b
flags usage difference is because one case disassembles only one section with
instructions, while the other case disassembles the whole file.

[Sven Panne, 2013-01-07 09:46:27]

lgtm