Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1156423006: Add a test for ContextualSearch Query URLs. (Closed)

Created:
5 years, 6 months ago by aurimas (slooooooooow)
Modified:
5 years, 6 months ago
Reviewers:
Ted C, Donn Denman, donnd
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for ContextualSearch Query URLs. Adds a test that validates that TemplateUrlService returns URLs with correct parameters. BUG=None Committed: https://crrev.com/eda6d4fc8ff677f52542fb875c48d27a802d5222 Cr-Commit-Position: refs/heads/master@{#333179}

Patch Set 1 #

Patch Set 2 : fix spelling of parameter #

Patch Set 3 : Fix test to not run on UI thread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java View 1 2 5 chunks +58 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
aurimas (slooooooooow)
PTAL
5 years, 6 months ago (2015-06-03 23:55:18 UTC) #2
donnd
lgtm Thanks for doing this Aurimas!
5 years, 6 months ago (2015-06-04 02:01:36 UTC) #4
aurimas (slooooooooow)
+tedchoc for owners review
5 years, 6 months ago (2015-06-04 03:51:32 UTC) #6
aurimas (slooooooooow)
+tedchoc for owners review
5 years, 6 months ago (2015-06-04 03:51:35 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156423006/20001
5 years, 6 months ago (2015-06-04 17:07:37 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/30000)
5 years, 6 months ago (2015-06-04 18:02:43 UTC) #11
Ted C
lgtm
5 years, 6 months ago (2015-06-04 18:41:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156423006/40001
5 years, 6 months ago (2015-06-05 23:24:40 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 23:50:30 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 23:51:37 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eda6d4fc8ff677f52542fb875c48d27a802d5222
Cr-Commit-Position: refs/heads/master@{#333179}

Powered by Google App Engine
This is Rietveld 408576698