Subrect snapshot support.

Subrect snapshot support.

Handle grabbing the subrect snapshot of a texture.  Leaving the old method
in there for now to deal with not breaking other repos when committing.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173863

[Ted C, 2012-12-14 21:36:02]

lgtm

[David Trainor- moved to gerrit, 2012-12-17 21:08:46]

sievers@: Could you look at render_widget_host_view_android?
mazda@: Wanted to get you on this for the changes to gl_helper since it looks
like you wrote it.
piman@: Can you also look at gl_helper?  Need an owner review.

Thanks!

[piman, 2012-12-17 21:12:24]

lgtm

[mazda, 2012-12-17 21:19:19]

gl_helper: lgtm

[no sievers, 2012-12-17 21:20:02]

https://chromiumcodereview.appspot.com/11558039/diff/4001/content/browser/and...
File content/browser/android/content_view_core_impl.cc (right):

https://chromiumcodereview.appspot.com/11558039/diff/4001/content/browser/and...
content/browser/android/content_view_core_impl.cc:555: return
GetScaledContentTexture(size, GetBounds());
Using GetBounds() here is racy during resizing, because this returns the size of
the view while the texture might have a different size.
I guess you have the same problem with passing in a source rect below, so it
would be better to always scale the whole thing and later copy out your subrect.
What's this used for?

[no sievers, 2012-12-17 23:48:59]

lgtm with one nit.

Yes, I think this is better - now you can copy out of the frontbuffer into a
different texture first, and then crop when you know the size of that texture
won't change.

https://codereview.chromium.org/11558039/diff/7003/content/public/browser/and...
File content/public/browser/android/compositor.h (right):

https://codereview.chromium.org/11558039/diff/7003/content/public/browser/and...
content/public/browser/android/compositor.h:96: // done.  It is assumed that the
texture size matches that of the bitmap.
update the comment -> "src_rect needs to match the size of the bitmap."
Maybe even return an error if it does not.

[David Trainor- moved to gerrit, 2012-12-18 19:14:31]

https://chromiumcodereview.appspot.com/11558039/diff/7003/content/public/brow...
File content/public/browser/android/compositor.h (right):

https://chromiumcodereview.appspot.com/11558039/diff/7003/content/public/brow...
content/public/browser/android/compositor.h:96: // done.  It is assumed that the
texture size matches that of the bitmap.
On 2012/12/17 23:48:59, Daniel Sievers wrote:
> update the comment -> "src_rect needs to match the size of the bitmap."
> Maybe even return an error if it does not.

Done.

[no sievers, 2012-12-18 19:33:19]

lgtm

https://chromiumcodereview.appspot.com/11558039/diff/11002/content/browser/re...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://chromiumcodereview.appspot.com/11558039/diff/11002/content/browser/re...
content/browser/renderer_host/compositor_impl_android.cc:272: if (bitmap.size()
!= sub_rect.size() || texture_id == 0) return false;
line break before return
I guess the dcheck() can go away now

[commit-bot: I haz the power, 2012-12-18 19:37:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11558039/11002

[commit-bot: I haz the power, 2012-12-18 20:04:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11558039/25001

[commit-bot: I haz the power, 2012-12-18 20:04:43]

Presubmit check for 11558039-25001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    android_webview

Presubmit checks took 1.1s to calculate.

[David Trainor- moved to gerrit, 2012-12-18 20:08:02]

Joth: Can you take a look at aw_contents?  Need an owner lgtm.  Thanks!

[joth, 2012-12-19 00:17:48]

lgtm

[commit-bot: I haz the power, 2012-12-19 00:22:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11558039/25001

[commit-bot: I haz the power, 2012-12-19 05:40:13]

Change committed as 173863