Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11558017: Decouple input_method from BrowserThread (and content/). (Closed)

Created:
8 years ago by erikwright (departed)
Modified:
8 years ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review nit. #

Patch Set 3 : Sync. #

Patch Set 4 : Fix build failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -91 lines) Patch
M chrome/browser/chromeos/input_method/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller.h View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.h View 1 5 chunks +21 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 1 2 3 10 chunks +38 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_delegate.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_delegate_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_delegate_impl.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_delegate.cc View 2 chunks +15 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/mock_sequenced_task_runner.h View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/mock_sequenced_task_runner.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_xkeyboard.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_xkeyboard.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard.h View 1 2 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard.cc View 10 chunks +25 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
erikwright (departed)
nona: PTAL.
8 years ago (2012-12-12 13:58:05 UTC) #1
Seigo Nonaka
lgtm lgtm Thank you for your cleaning up! https://codereview.chromium.org/11558017/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl.h File chrome/browser/chromeos/input_method/ibus_controller_impl.h (right): https://codereview.chromium.org/11558017/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl.h#newcode38 chrome/browser/chromeos/input_method/ibus_controller_impl.h:38: IBusControllerImpl( ...
8 years ago (2012-12-13 05:40:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11558017/4002
8 years ago (2012-12-14 14:14:03 UTC) #3
commit-bot: I haz the power
Presubmit check for 11558017-4002 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-14 14:14:13 UTC) #4
erikwright (departed)
jochen, PTAL for chrome_tests_unit.gypi and API update (static to instance method) in c/b/chromeos/preferences.cc
8 years ago (2012-12-14 14:17:19 UTC) #5
jochen (gone - plz use gerrit)
lgtm
8 years ago (2012-12-14 15:06:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11558017/4002
8 years ago (2012-12-14 15:24:15 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-14 15:50:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11558017/4002
8 years ago (2012-12-14 16:08:41 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-14 20:21:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11558017/4002
8 years ago (2012-12-14 20:32:40 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 03:59:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11558017/4002
8 years ago (2012-12-17 15:18:36 UTC) #13
commit-bot: I haz the power
Change committed as 173477
8 years ago (2012-12-17 16:47:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11558017/20001
8 years ago (2012-12-21 21:23:02 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-21 23:08:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11558017/20001
8 years ago (2012-12-22 00:08:59 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-22 04:30:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11558017/20001
8 years ago (2012-12-22 15:47:29 UTC) #19
commit-bot: I haz the power
8 years ago (2012-12-22 18:03:30 UTC) #20
Message was sent while issue was closed. 
Change committed as 174534

Powered by Google App Engine
This is Rietveld 408576698