Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java

Issue 11555004: Refactoring JavaScript modal dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed proguard Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java
diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java
index 841787a372dcfbb371fe9cf404386bfbcc1773f8..c7079ed0fe7470742d4d5504efdd74217cac7dce 100644
--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java
+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java
@@ -127,15 +127,18 @@ public class TestCallbackHelperContainer {
}
/**
- * Waits till the JavaScript evaluation finishes.
+ * Waits till the JavaScript evaluation finishes and returns true if a value was returned,
+ * false if it timed-out.
*/
- public void waitUntilHasValue(long timeout, TimeUnit timeoutUnits)
+ public boolean waitUntilHasValue(long timeout, TimeUnit timeoutUnits)
throws InterruptedException, TimeoutException {
waitUntilCriteria(getHasValueCriteria(), timeout, timeoutUnits);
+ return hasValue();
}
- public void waitUntilHasValue() throws InterruptedException, TimeoutException {
+ public boolean waitUntilHasValue() throws InterruptedException, TimeoutException {
waitUntilCriteria(getHasValueCriteria());
+ return hasValue();
}
private void setRequestId(Integer requestId) {
« no previous file with comments | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698