Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2655)

Unified Diff: build/android/pylib/apk_info.py

Issue 11555004: Refactoring JavaScript modal dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed proguard Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/js_modal_dialog.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/apk_info.py
diff --git a/build/android/pylib/apk_info.py b/build/android/pylib/apk_info.py
index 2040f2444ccf59a48563356db7d29bfe051a400f..00b30ddaaa3f803b0a8eee6609479ff8f454371c 100644
--- a/build/android/pylib/apk_info.py
+++ b/build/android/pylib/apk_info.py
@@ -95,6 +95,7 @@ class ApkInfo(object):
clazz = m.group(1).replace('/', '.') # Change package delim.
annotation = None
continue
+
m = self._PROGUARD_METHOD_RE.match(line)
if m:
method = m.group(1)
@@ -103,15 +104,18 @@ class ApkInfo(object):
if method.startswith('test') and clazz.endswith('Test'):
self._test_methods += [qualified_method]
continue
+
+ if not qualified_method:
+ # Ignore non-method annotations.
+ continue
+
m = self._PROGUARD_ANNOTATION_RE.match(line)
if m:
- assert qualified_method
annotation = m.group(1).split('/')[-1] # Ignore the annotation package.
self._annotation_map[qualified_method].append(annotation)
has_value = False
continue
if annotation:
- assert qualified_method
if not has_value:
m = self._PROGUARD_ANNOTATION_CONST_RE.match(line)
if m:
« no previous file with comments | « no previous file | chrome/android/java/res/layout/js_modal_dialog.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698