Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 11555002: cc: Fix invalidation problems in impl-side painting (Closed)

Created:
8 years ago by enne (OOO)
Modified:
8 years ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Fix invalidation problems in impl-side painting The PictureLayerTiling iterator used to stop when it hit a null tile rather than iterating through null tiles. So, some invalidations were ignored because the iterator would hit a null tile from a previous invalidation rect on the same frame and abort. This is fixed by making the PictureLayerTiling iterator walk over all i, j pairs, regardless of whether there is a tile there or not. The PictureLayerTilingSet iteration is also made robust to this possibility. R=nduca@chromium.org BUG=165246, 165336 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/picture_layer_tiling.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/picture_layer_tiling_set.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
8 years ago (2012-12-11 22:48:45 UTC) #1
nduca
lgtm
8 years ago (2012-12-11 23:13:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11555002/1
8 years ago (2012-12-11 23:25:20 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-12 02:35:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11555002/1
8 years ago (2012-12-12 03:20:33 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-12 04:06:12 UTC) #6
Message was sent while issue was closed.
Change committed as 172519

Powered by Google App Engine
This is Rietveld 408576698