Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 11554028: Don't fail at gyp time if arm-sysroot is missing. (Closed)

Created:
8 years ago by Sam Clegg
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Don't fail at gyp time if arm-sysroot is missing. This fixes the NaCl SDK build which builds with target_arch=arm but only builds untrusted targets so doesn't need the arm sysroot. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173045

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
8 years ago (2012-12-12 18:25:15 UTC) #1
noelallen_use_chromium
LGTM
8 years ago (2012-12-12 18:44:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11554028/15001
8 years ago (2012-12-13 22:10:52 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-14 01:53:45 UTC) #4
Message was sent while issue was closed.
Change committed as 173045

Powered by Google App Engine
This is Rietveld 408576698