Issue 11553016: Sync PRESUBMIT.py with what is run on CQ.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11553016: Sync PRESUBMIT.py with what is run on CQ. (Closed)

Created:
8 years ago by Mike Stip (use stip instead)

Modified:
6 years, 10 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Sync PRESUBMIT.py with what is run on CQ. BUG=108484

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -7 lines)			Patch
	M	PRESUBMIT.py	View		3 chunks	+111 lines, -7 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Stip (use stip instead)

maruel -- this fails in presubmit_support.py, line 924 with 'Do not use \',\' separated builder ...

8 years ago (2012-12-12 07:31:52 UTC) #1

M-A Ruel

8 years ago (2012-12-12 17:54:59 UTC) #2

https://chromiumcodereview.appspot.com/11553016/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/11553016/diff/1/PRESUBMIT.py#newcode936
PRESUBMIT.py:936: bot_list[builder] = (builder + ':' +
','.join(list(set(tests))))
What about we convert the code in depot_tools to use a dict(str, set(str))
instead? That would:
1. Greatly reduce the string parsing.
2. Make it easy to add a test *safely*:
out.setdefault('buider', set().add('test')

That requires more plumbing but it probably makes sense to do it before relying
on it everywhere?

The "consumer code" is in presubmit_support.py.

https://chromiumcodereview.appspot.com/11553016/diff/1/PRESUBMIT.py#newcode965
PRESUBMIT.py:965: 'android_clang_dbg',
In theory, all this list disappears.

Expand Messages | Collapse Messages