Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1155223003: Uprev NSS from 3.18.0 RTM to 3.19.0 RTM (Closed)

Created:
5 years, 6 months ago by Ryan Sleevi
Modified:
5 years, 6 months ago
Reviewers:
davidben
Target Ref:
refs/remotes/origin/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebase to ToT #

Patch Set 3 : *cough* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2074 lines, -705 lines) Patch
M README.chromium View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M nss/lib/certdb/cert.h View 2 chunks +17 lines, -0 lines 0 comments Download
M nss/lib/certdb/certt.h View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/certdb/genname.c View 2 chunks +89 lines, -66 lines 0 comments Download
M nss/lib/ckfw/builtins/certdata.c View 184 chunks +310 lines, -310 lines 0 comments Download
M nss/lib/ckfw/builtins/nssckbi.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + nss/lib/freebl/intel-aes-x64-masm.asm View 21 chunks +277 lines, -255 lines 0 comments Download
M nss/lib/freebl/intel-gcm.h View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/freebl/intel-gcm-wrap.c View 7 chunks +51 lines, -38 lines 0 comments Download
A nss/lib/freebl/intel-gcm-x64-masm.asm View 1 chunk +1295 lines, -0 lines 0 comments Download
M nss/lib/freebl/mpi/mpmontg.c View 6 chunks +18 lines, -13 lines 0 comments Download
M nss/lib/libpkix/pkix_pl_nss/module/pkix_pl_httpdefaultclient.c View 2 chunks +0 lines, -4 lines 0 comments Download
M nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_publickey.c View 2 chunks +0 lines, -3 lines 0 comments Download
M nss/lib/nss/nss.h View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/softoken/softkver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/util/nssutil.h View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/nss-checkout.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
David: Please take a look. 3.19 was named because it added the new API (for ...
5 years, 6 months ago (2015-05-27 00:46:15 UTC) #1
davidben
lgtm https://codereview.chromium.org/1155223003/diff/1/README.chromium File README.chromium (right): https://codereview.chromium.org/1155223003/diff/1/README.chromium#newcode47 README.chromium:47: bug 1126408 (https://bugzilla.mozilla.org/show_bug.cgi?id=1126408). Hrm, I thought I already ...
5 years, 6 months ago (2015-05-27 19:40:40 UTC) #2
Ryan Sleevi
https://codereview.chromium.org/1155223003/diff/1/nss/lib/ckfw/builtins/certdata.c File nss/lib/ckfw/builtins/certdata.c (right): https://codereview.chromium.org/1155223003/diff/1/nss/lib/ckfw/builtins/certdata.c#newcode957 nss/lib/ckfw/builtins/certdata.c:957: + CKA_CLASS, CKA_TOKEN, CKA_PRIVATE, CKA_MODIFIABLE, CKA_LABEL, CKA_ISSUER, CKA_SERIAL_NUMBER, CKA_TRUST_SERVER_AUTH, ...
5 years, 6 months ago (2015-05-27 23:04:40 UTC) #3
Ryan Sleevi
5 years, 6 months ago (2015-05-27 23:07:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 295435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698