Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2210)

Unified Diff: cc/layer_tree_host_impl.cc

Issue 11552009: Add support for calculating the position of the top controls in the cc layer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add missing CC_EXPORT...learn to run try jobs manually Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layer_tree_host_impl.h ('k') | cc/layer_tree_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layer_tree_host_impl.cc
diff --git a/cc/layer_tree_host_impl.cc b/cc/layer_tree_host_impl.cc
index e6b9ac99e0d49ae673f001b56a4ce6ad514d74aa..3e5792aa49c1d0f81de4b08bd79fd34d34c7d4c1 100644
--- a/cc/layer_tree_host_impl.cc
+++ b/cc/layer_tree_host_impl.cc
@@ -37,6 +37,7 @@
#include "cc/software_renderer.h"
#include "cc/solid_color_draw_quad.h"
#include "cc/texture_uploader.h"
+#include "cc/top_controls_manager.h"
#include "cc/util.h"
#include "ui/gfx/size_conversions.h"
#include "ui/gfx/vector2d_conversions.h"
@@ -155,6 +156,9 @@ LayerTreeHostImpl::LayerTreeHostImpl(const LayerTreeSettings& settings, LayerTre
DCHECK(m_proxy->isImplThread());
didVisibilityChange(this, m_visible);
+ if (settings.calculateTopControlsPosition)
+ m_topControlsManager = TopControlsManager::Create(this, settings.topControlsHeightPx);
+
// LTHI always has an active tree.
m_activeTree = LayerTreeImpl::create(this);
}
@@ -230,6 +234,8 @@ void LayerTreeHostImpl::animate(base::TimeTicks monotonicTime, base::Time wallCl
animatePageScale(monotonicTime);
animateLayers(monotonicTime, wallClockTime);
animateScrollbars(monotonicTime);
+ if (m_topControlsManager)
+ m_topControlsManager->Animate(monotonicTime);
}
void LayerTreeHostImpl::manageTiles()
@@ -331,6 +337,8 @@ void LayerTreeHostImpl::updateDrawProperties()
return;
}
+ if (m_topControlsManager)
+ m_topControlsManager->UpdateDrawPositions();
activeTree()->UpdateDrawProperties();
if (pendingTree())
pendingTree()->UpdateDrawProperties();
@@ -772,6 +780,10 @@ CompositorFrameMetadata LayerTreeHostImpl::makeCompositorFrameMetadata() const
metadata.root_layer_size = contentSize();
metadata.min_page_scale_factor = m_pinchZoomViewport.min_page_scale_factor();
metadata.max_page_scale_factor = m_pinchZoomViewport.max_page_scale_factor();
+ if (m_topControlsManager) {
+ metadata.location_bar_offset = gfx::Vector2dF(0.f, m_topControlsManager->controls_top_offset());
+ metadata.location_bar_content_translation = gfx::Vector2dF(0.f, m_topControlsManager->content_top_offset());
+ }
return metadata;
}
@@ -898,6 +910,11 @@ static LayerImpl* findScrollLayerForContentLayer(LayerImpl* layerImpl)
return 0;
}
+LayerTreeImpl* LayerTreeHostImpl::activeTree()
+{
+ return m_activeTree.get();
+}
+
void LayerTreeHostImpl::createPendingTree()
{
CHECK(!m_pendingTree);
@@ -1098,6 +1115,11 @@ void LayerTreeHostImpl::updateMaxScrollOffset()
pendingTree()->UpdateMaxScrollOffset();
}
+void LayerTreeHostImpl::setNeedsUpdateDrawProperties()
+{
+ m_needsUpdateDrawProperties = true;
+}
+
void LayerTreeHostImpl::setNeedsRedraw()
{
m_client->setNeedsRedrawOnImplThread();
@@ -1113,6 +1135,9 @@ InputHandlerClient::ScrollStatus LayerTreeHostImpl::scrollBegin(gfx::Point viewp
{
TRACE_EVENT0("cc", "LayerTreeHostImpl::scrollBegin");
+ if (m_topControlsManager)
+ m_topControlsManager->ScrollBegin();
+
DCHECK(!currentlyScrollingLayer());
clearCurrentlyScrollingLayer();
@@ -1245,6 +1270,9 @@ bool LayerTreeHostImpl::scrollBy(const gfx::Point& viewportPoint,
if (m_settings.pageScalePinchZoomEnabled && layerImpl == rootScrollLayer())
viewport = &m_pinchZoomViewport;
gfx::Vector2dF appliedDelta;
+ if (m_topControlsManager && layerImpl == rootScrollLayer())
+ pendingDelta = m_topControlsManager->ScrollBy(pendingDelta);
+
if (m_scrollDeltaIsInViewportSpace) {
float scaleFromViewportToScreenSpace = m_deviceScaleFactor;
appliedDelta = scrollLayerWithViewportSpaceDelta(viewport, *layerImpl, scaleFromViewportToScreenSpace, viewportPoint, pendingDelta);
@@ -1289,6 +1317,8 @@ void LayerTreeHostImpl::clearCurrentlyScrollingLayer()
void LayerTreeHostImpl::scrollEnd()
{
+ if (m_topControlsManager)
+ m_topControlsManager->ScrollEnd();
clearCurrentlyScrollingLayer();
}
« no previous file with comments | « cc/layer_tree_host_impl.h ('k') | cc/layer_tree_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698