cc: Fix tile deletion.

cc: Fix tile deletion.

Tile pointers are left in tiles_that_need_to_be_rasterized_ vector
until ManageTiles() or AssignGpuMemoryToTiles() are called.

BUG=165852
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173039

[reveman, 2012-12-13 03:36:17]

I'm working on a better way to handle tile deletion but created this CL in case
we need a quick fix. This is currently causing crashes but they seem relatively
unlikely as we currently call AssignGpuMemoryToTiles() all the time.

[enne (OOO), 2012-12-13 04:08:43]

I had actually talked with Nat about this sort of approach a long time ago.  One
other approach I considered was that if a tile has an outstanding raster job,
maybe the manager needs to take a ref on it?

[reveman, 2012-12-13 04:39:40]

On 2012/12/13 04:08:43, enne wrote:
> I had actually talked with Nat about this sort of approach a long time ago. 
One
> other approach I considered was that if a tile has an outstanding raster job,
> maybe the manager needs to take a ref on it?

yes, we're already doing that. the task completed closure takes a ref.

[nduca, 2012-12-13 09:29:14]

I dont get why we need this. This should just work.

[nduca, 2012-12-13 09:34:35]

Oh, I get it. i'd prefer that tiles_that_need_Tobe_rasterized just has ref to
everyt ile in the raster queue. unregster causes manage tiles. that'll clear the
queue. done.

[reveman, 2012-12-13 18:18:11]

On 2012/12/13 09:34:35, nduca wrote:
> Oh, I get it. i'd prefer that tiles_that_need_Tobe_rasterized just has ref to
> everyt ile in the raster queue. unregster causes manage tiles. that'll clear
the
> queue. done.

we can keep refs in tiles_that_need_to_be_rasterized but we need to make sure
ManageTiles() is called. unregister wont be called if you a hold ref to a tile.
we should also make unregister more efficient. it currently iterates over all
tiles and erases an element from the middle of the tiles_ vector each time a
tile is deleted. we can do that much more efficiently if deletion is delayed
until ManageTiles() is called.

[nduca, 2012-12-13 18:29:45]

Oh, I get it. Okay, this lgtm.

[reveman, 2012-12-13 20:32:49]

ok, I'll land this for now as it blocks
https://codereview.chromium.org/11557017. I'm also working on a better solution
for deleting tiles but I don't think there's a huge rush to land that right now.

[commit-bot: I haz the power, 2012-12-13 20:33:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/11549038/1

[commit-bot: I haz the power, 2012-12-13 22:25:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/11549038/12002

[commit-bot: I haz the power, 2012-12-14 01:42:45]

Change committed as 173039