Issue 11548023: Cleanup tests for StringCharacterStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11548023: Cleanup tests for StringCharacterStream (Closed)

Created:
8 years ago by drcarney

Modified:
8 years ago

Reviewers:
Michael Starzinger, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleanup tests for StringCharacterStream Edge case tests now cover all branches. R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13217

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+424 lines, -227 lines)			Patch
	M	test/cctest/test-strings.cc	View		12 chunks	+424 lines, -227 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years ago (2012-12-14 09:23:07 UTC) #2

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/11548023/diff/1/test/cctest/test-strin...
File test/cctest/test-strings.cc (right):

https://chromiumcodereview.appspot.com/11548023/diff/1/test/cctest/test-strin...
test/cctest/test-strings.cc:874: TEST(StringCharacterStreamRandom) {
This test is failing on the GC Stress builder.

http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%201/build...

Expand Messages | Collapse Messages