Turn on the ADDRESS_SANITIZER on all platform when asan==1.

Turn on the ADDRESS_SANITIZER on all platform when asan==1.


BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173020

[Sébastien Marchand, 2012-12-13 15:36:15]

PTAL.

[iannucci, 2012-12-13 16:39:38]

On 2012/12/13 15:36:15, sebmarchand1 wrote:
> PTAL.

Previous condition was:
'os_posix==1 and OS!="mac" and OS!="ios"

But I'm assuming that it's not a problem if this is defined on mac and ios?

If so, lgtm. :)

[Sébastien Marchand, 2012-12-13 16:53:33]

I think that in an ideal world the ADDRESS_SANITIZER define shouldn't be
platform specific (if 'asan'==1 then ADDRESS_SANITIZER should be defined)... But
I probably should use the safest approach here and add this define one OS at a
time...

[Sébastien Marchand, 2012-12-13 16:53:35]

I think that in an ideal world the ADDRESS_SANITIZER define shouldn't be
platform specific (if 'asan'==1 then ADDRESS_SANITIZER should be defined)... But
I probably should use the safest approach here and add this define one OS at a
time...

[Sébastien Marchand, 2012-12-13 18:11:18]

PTA(nother)L.

[iannucci, 2012-12-13 18:16:04]

On 2012/12/13 18:11:18, sebmarchand1 wrote:
> PTA(nother)L.

lgtm. 

I do agree that asan==1 should always define ADDRESS_SANITIZER, so it would be
good to understand what that define does. It looks like it does have some effect
on OS X tho (check cs.chromium.org). It would be worth cleaning this up in
another cl after we get the win asan bots clean.

[commit-bot: I haz the power, 2012-12-13 18:58:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/11547031/7003

[commit-bot: I haz the power, 2012-12-13 20:48:44]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-13 21:13:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/11547031/7003

[commit-bot: I haz the power, 2012-12-14 00:40:26]

Change committed as 173020