Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 11547023: Make it harder to accidentally run envsetup.sh in a subshell (Closed)

Created:
8 years ago by Ami GONE FROM CHROMIUM
Modified:
8 years ago
Reviewers:
Yaron, Isaac (away)
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Make it harder to accidentally run envsetup.sh in a subshell (instead of sourcing it in the current shell). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172828

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/android/envsetup.sh View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ami GONE FROM CHROMIUM
8 years ago (2012-12-12 20:59:56 UTC) #1
Isaac (away)
Alternatively you could chmod -x this. Although if you do that you have to remove ...
8 years ago (2012-12-12 21:04:10 UTC) #2
Ami GONE FROM CHROMIUM
On 2012/12/12 21:04:10, Isaac wrote: > Alternatively you could chmod -x this. > > Although ...
8 years ago (2012-12-12 21:13:03 UTC) #3
Yaron
lgtm
8 years ago (2012-12-12 23:40:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/11547023/1002
8 years ago (2012-12-12 23:56:56 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-13 05:58:41 UTC) #6
Message was sent while issue was closed.
Change committed as 172828

Powered by Google App Engine
This is Rietveld 408576698