Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5810)

Unified Diff: ash/metrics/user_metrics_recorder.h

Issue 1153633006: Added UMA statistics for changing the active window via click or touch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added the missed desktop_task_switch_metric_recorder files. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/metrics/user_metrics_recorder.h
diff --git a/ash/metrics/user_metrics_recorder.h b/ash/metrics/user_metrics_recorder.h
index 7bb6f9d52d992bd59518523a4cd44733c4f2bb23..186b9269617e0adb4adaf7d02d76a793d2eb5d94 100644
--- a/ash/metrics/user_metrics_recorder.h
+++ b/ash/metrics/user_metrics_recorder.h
@@ -7,10 +7,13 @@
#include "ash/ash_export.h"
#include "ash/metrics/task_switch_metrics_recorder.h"
+#include "base/memory/scoped_ptr.h"
#include "base/timer/timer.h"
namespace ash {
+class DesktopTaskSwitchMetricRecorder;
+
namespace test {
class UserMetricsRecorderTestAPI;
}
@@ -27,6 +30,7 @@ enum UserMetricsAction {
UMA_ACCEL_RESTART_POWER_BUTTON,
UMA_ACCEL_SHUT_DOWN_POWER_BUTTON,
UMA_CLOSE_THROUGH_CONTEXT_MENU,
+ UMA_DESKTOP_SWITCH_TASK,
UMA_DRAG_MAXIMIZE_LEFT,
UMA_DRAG_MAXIMIZE_RIGHT,
UMA_GESTURE_OVERVIEW,
@@ -153,6 +157,12 @@ class ASH_EXPORT UserMetricsRecorder {
return task_switch_metrics_recorder_;
}
+ // Informs |this| that the Shell has been initialized.
+ void OnShellInitialized();
+
+ // Informs |this| that the Shell is going to be shut down.
+ void OnShellShuttingDown();
+
private:
friend class test::UserMetricsRecorderTestAPI;
@@ -179,6 +189,10 @@ class ASH_EXPORT UserMetricsRecorder {
TaskSwitchMetricsRecorder task_switch_metrics_recorder_;
+ // The metric recorder for click and tap input events.
tdanderson 2015/06/04 22:15:51 nit: specify in this comment that it's specificall
bruthig 2015/06/05 17:28:21 Done.
+ scoped_ptr<DesktopTaskSwitchMetricRecorder>
+ desktop_task_switch_metric_recorder_;
+
DISALLOW_COPY_AND_ASSIGN(UserMetricsRecorder);
};

Powered by Google App Engine
This is Rietveld 408576698