Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 11536006: Android: fix breakpad_unittests execution. (Closed)

Created:
8 years ago by digit1
Modified:
8 years ago
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Android: fix breakpad_unittests execution. The build/android/ scripts could not run the breakpad_unittests script properly for two reasons: - First, a special helper binary needs to be pushed to the device. This patch modifies test_package.py to take care of that. - Second, the GTest result value file is stored in /data/local/tmp/ for executable tests, instead of /sdcard/, as assumed by test_package_executable.py. BUG=165355 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172513

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : re-enable breakpad unittests #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
D build/android/gtest_filter/breakpad_unittests_disabled View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
M build/android/pylib/test_package.py View 1 chunk +4 lines, -0 lines 0 comments Download
M build/android/pylib/test_package_executable.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
digit1
Does anyone knows why the patch fails to apply on the buildbots?
8 years ago (2012-12-11 15:47:23 UTC) #1
bulach
lgtm no idea re: try bots, but the file seems to be marked as "deleted" ...
8 years ago (2012-12-11 16:43:54 UTC) #2
digit1
Apparently, this needed a gclient resync. Things are looking better now :)
8 years ago (2012-12-11 17:23:50 UTC) #3
Yaron
lgtm
8 years ago (2012-12-11 18:22:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/11536006/11001
8 years ago (2012-12-11 21:25:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-11 23:36:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/11536006/11001
8 years ago (2012-12-12 02:46:18 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-12 03:12:23 UTC) #8
Message was sent while issue was closed.
Change committed as 172513

Powered by Google App Engine
This is Rietveld 408576698