Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: ui/gfx/render_text_win.h

Issue 11535014: Replace StyleRange with BreakList; update RenderText, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text_unittest.cc ('k') | ui/gfx/render_text_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_win.h
diff --git a/ui/gfx/render_text_win.h b/ui/gfx/render_text_win.h
index 8b42bc9f076d52ee00b43446e0c4ad9e579225ba..a419669a0a383ae0eb721d98319e2729893cc71d 100644
--- a/ui/gfx/render_text_win.h
+++ b/ui/gfx/render_text_win.h
@@ -25,14 +25,14 @@ struct TextRun {
ui::Range range;
Font font;
- // TODO(msw): Disambiguate color, strike, etc. from TextRuns.
- // Otherwise, this breaks the glyph shaping process.
- // See the example at: http://www.catch22.net/tuts/neatpad/12.
- SkColor foreground;
// A gfx::Font::FontStyle flag to specify bold and italic styles.
// Supersedes |font.GetFontStyle()|. Stored separately to avoid calling
// |font.DeriveFont()|, which is expensive on Windows.
int font_style;
+
+ // TODO(msw): Disambiguate color/style from TextRuns for proper glyph shaping.
+ // See an example: http://www.catch22.net/tuts/uniscribe-mysteries
+ SkColor foreground;
bool strike;
bool diagonal_strike;
bool underline;
« no previous file with comments | « ui/gfx/render_text_unittest.cc ('k') | ui/gfx/render_text_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698