ui/gfx/font_list.cc - Issue 11535014: Replace StyleRange with BreakList; update RenderText, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/font_list.cc

Issue 11535014: Replace StyleRange with BreakList; update RenderText, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/font_list.cc

diff --git a/ui/gfx/font_list.cc b/ui/gfx/font_list.cc

index dc42c2f3d74d4333e59c37d44db1d2943590b9ce..464e7229246f6152c62974c13303bc5070de0541 100644

--- a/ui/gfx/font_list.cc

+++ b/ui/gfx/font_list.cc

@@ -28,8 +28,7 @@ void ParseFontDescriptionString(const std::string& font_description_string,

DCHECK_GT(*font_size, 0);

font_names->pop_back();

- // Besides underline (which is supported through StyleRange), Font only

- // supports BOLD and ITALIC, but not other styles.

+ // Font supports BOLD and ITALIC; underline is supported via RenderText.

*font_style = 0;

for (size_t i = 0; i < styles_size.size() - 1; ++i) {

// Styles are separated by white spaces. base::SplitString splits styles

« no previous file with comments | « ui/gfx/font.h ('k') | ui/gfx/pango_util.cc » ('j') | no next file with comments »