Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 11534010: Pass a list of strings rather than a string-as-list. (Closed)

Created:
8 years ago by Jói
Modified:
8 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, no longer working on chromium
Visibility:
Public.

Description

Pass a list of strings rather than a string-as-list. This fixes a stupid bug that got past my testing (I tested the positive case but not the negative). TBR=maruel@chromium.org NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172328

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jói
Will TBR so more people don't get a false-positive. Cheers, Jói
8 years ago (2012-12-11 14:58:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/11534010/1
8 years ago (2012-12-11 14:58:22 UTC) #2
M-A Ruel
You can use NOTRY=true to skip the try jobs https://codereview.chromium.org/11534010/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/11534010/diff/1/PRESUBMIT.py#newcode670 PRESUBMIT.py:670: ...
8 years ago (2012-12-11 15:03:47 UTC) #3
Jói
Thanks, added r prefix for string. Committing now.
8 years ago (2012-12-11 15:11:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/11534010/10002
8 years ago (2012-12-11 15:11:50 UTC) #5
commit-bot: I haz the power
Change committed as 172328
8 years ago (2012-12-11 15:11:58 UTC) #6
M-A Ruel
8 years ago (2012-12-11 15:12:40 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698