Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: pkg/compiler/lib/src/js_backend/constant_emitter.dart

Issue 1153243003: dart2js: Use frequency of occurence to sort metadata indices. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sra comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/constant_emitter.dart
diff --git a/pkg/compiler/lib/src/js_backend/constant_emitter.dart b/pkg/compiler/lib/src/js_backend/constant_emitter.dart
index b113d2409c116face6a1c46e6fe3ec4f641d6111..5f75836895cab482b507e7231017221cd1bbede1 100644
--- a/pkg/compiler/lib/src/js_backend/constant_emitter.dart
+++ b/pkg/compiler/lib/src/js_backend/constant_emitter.dart
@@ -263,8 +263,18 @@ class ConstantEmitter
}
@override
- jsAst.Expression visitDummy(DummyConstantValue constant, [_]) {
- return new jsAst.LiteralNumber('0');
+ jsAst.Expression visitSynthetic(SyntheticConstantValue constant, [_]) {
+ switch (constant.kind) {
+ case SyntheticConstantKind.DUMMY_RECEIVER:
+ case SyntheticConstantKind.EMPTY_VALUE:
+ return new jsAst.LiteralNumber('0');
+ case SyntheticConstantKind.TYPEVARIABLE_REFERENCE:
+ return constant.payload;
+ default:
+ compiler.internalError(NO_LOCATION_SPANNABLE,
+ "Unexpected DummyConstantKind ${constant.kind}");
+ return null;
+ }
}
@override

Powered by Google App Engine
This is Rietveld 408576698