Issue 11532011: Renamed classes for consistency.

Issue 11532011: Renamed classes for consistency. (Closed)

Created:
8 years ago by agayev

Modified:
8 years ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, sadrul, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org, ben+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Renamed classes for consistency. BUG=157187 TEST=net_unittests --gtest_filter="FlashCacheTest.*" --gtest_repeat=10 --shuffle Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172651

Patch Set 3 : test 2. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -774 lines)			Patch
D	net/disk_cache/flash/cache_entry.h	View		1 chunk	+0 lines, -63 lines	0 comments	Download
D	net/disk_cache/flash/cache_entry.cc	View		1 chunk	+0 lines, -162 lines	0 comments	Download
D	net/disk_cache/flash/cache_entry_unittest.cc	View		1 chunk	+0 lines, -59 lines	0 comments	Download
M	net/disk_cache/flash/flash_cache_test_base.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/flash/flash_cache_test_base.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	net/disk_cache/flash/format.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	net/disk_cache/flash/log_store.h	View		4 chunks	+11 lines, -11 lines	0 comments	Download
A +	net/disk_cache/flash/log_store.cc	View		10 chunks	+12 lines, -12 lines	0 comments	Download
A +	net/disk_cache/flash/log_store_entry.h	View		3 chunks	+11 lines, -11 lines	0 comments	Download
A +	net/disk_cache/flash/log_store_entry.cc	View		6 chunks	+34 lines, -34 lines	0 comments	Download
A +	net/disk_cache/flash/log_store_entry_unittest.cc	View		3 chunks	+15 lines, -14 lines	0 comments	Download
A	net/disk_cache/flash/log_store_unittest.cc	View	2	1 chunk	+114 lines, -0 lines	0 comments	Download
D	net/disk_cache/flash/log_structured_store.h	View		1 chunk	+0 lines, -102 lines	0 comments	Download
D	net/disk_cache/flash/log_structured_store.cc	View		1 chunk	+0 lines, -175 lines	0 comments	Download
D	net/disk_cache/flash/log_structured_store_unittest.cc	View	2	1 chunk	+0 lines, -114 lines	0 comments	Download
M	net/net.gyp	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

lgtm https://codereview.chromium.org/11532011/diff/1/net/disk_cache/flash/log_store.h File net/disk_cache/flash/log_store.h (right): https://codereview.chromium.org/11532011/diff/1/net/disk_cache/flash/log_store.h#newcode59 net/disk_cache/flash/log_store.h:59: LogStoreReadFromClosedSegment); nit: Most of these should fit in ...

8 years ago (2012-12-11 20:40:42 UTC) #2

agayev

https://codereview.chromium.org/11532011/diff/1/net/disk_cache/flash/log_store.h File net/disk_cache/flash/log_store.h (right): https://codereview.chromium.org/11532011/diff/1/net/disk_cache/flash/log_store.h#newcode59 net/disk_cache/flash/log_store.h:59: LogStoreReadFromClosedSegment); On 2012/12/11 20:40:42, rvargas wrote: > nit: Most ...

8 years ago (2012-12-11 21:12:40 UTC) #3

rvargas (doing something else)

On 2012/12/11 21:12:40, agayev wrote: > https://codereview.chromium.org/11532011/diff/1/net/disk_cache/flash/log_store.h > File net/disk_cache/flash/log_store.h (right): > > https://codereview.chromium.org/11532011/diff/1/net/disk_cache/flash/log_store.h#newcode59 > ...

8 years ago (2012-12-11 21:38:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agayev@chromium.org/11532011/6001

8 years ago (2012-12-12 17:14:33 UTC) #5

Message was sent while issue was closed.

Change committed as 172651

Expand Messages | Collapse Messages