chrome/browser/net/dns_probe_job_unittest.cc - Issue 11530018: DnsProbeJob: Differentiate network and DNS errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/dns_probe_job_unittest.cc

Issue 11530018: DnsProbeJob: Differentiate network and DNS errors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rename IsDnsServerError to DidReceiveDnsResponse Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/dns_probe_job_unittest.cc

diff --git a/chrome/browser/net/dns_probe_job_unittest.cc b/chrome/browser/net/dns_probe_job_unittest.cc

index ce2bf8563a4e2d59020ab390eeb8299e4d652656..06d6965527ca725967fe1fad8247e7540145a319 100644

--- a/chrome/browser/net/dns_probe_job_unittest.cc

+++ b/chrome/browser/net/dns_probe_job_unittest.cc

@@ -106,9 +106,12 @@ TEST_F(DnsProbeJobTest, Test) {

// (Need to add another mock behavior to MockDnsClient.)

{ MockDnsClientRule::FAIL_ASYNC,

MockDnsClientRule::FAIL_ASYNC,

- DnsProbeJob::SERVERS_UNREACHABLE },

+ DnsProbeJob::SERVERS_FAILING },

{ MockDnsClientRule::FAIL_SYNC,

MockDnsClientRule::FAIL_SYNC,

+ DnsProbeJob::SERVERS_FAILING },

+ { MockDnsClientRule::TIMEOUT,

+ MockDnsClientRule::TIMEOUT,

DnsProbeJob::SERVERS_UNREACHABLE },

};

for (size_t i = 0; i < arraysize(kTestCases); i++) {

« no previous file with comments | « chrome/browser/net/dns_probe_job.cc ('k') | net/dns/dns_test_util.h » ('j') | no next file with comments »