Issue 11530011: Avoid object layout changes during GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11530011: Avoid object layout changes during GC. (Closed)

Created:
8 years ago by Yang

Modified:
8 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Avoid object layout changes during GC. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13194

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -22 lines)			Patch
M	src/heap.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/messages.js	View		5 chunks	+22 lines, -13 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+24 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years ago (2012-12-11 14:52:35 UTC) #2

LGTM (with a nit).

https://codereview.chromium.org/11530011/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/11530011/diff/1/src/runtime.cc#newcode13115
src/runtime.cc:13115: ASSERT_EQ(args.length(), 1);
This method should either have a NoHandleAllocation scope or it's own
HandleScope.

https://codereview.chromium.org/11530011/diff/1/src/runtime.cc#newcode13128
src/runtime.cc:13128: ASSERT_EQ(args.length(), 2);
Likewise.

Expand Messages | Collapse Messages