Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 11530006: chromium-build app now renders merged console from stored rows. (Closed)

Created:
8 years ago by agable
Modified:
7 years, 10 months ago
Reviewers:
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

chromium-build app now renders merged console from stored rows. This is the full change to get the chromium-build app to render the merged console from individual rows rather than from full pages. It is mostly a rewrite of the logic in console_merger to handle fetching individual row data and passing it to the ConsoleData object, which is then inserted into the template. This CL puts the row-based rendering flow at feature-parity with the current console. The next, much smaller, CL is a series of small changes to handler.py and a few surrounding files to add proper url query parameter handling and to pass the user's ?rows=# request through to the merger. This CL also rewrites the console_merger tests to accurately test the new row-based system, and removes the utf8 test as it is covered by console_handler_utf8 and parse_master. The app in this form passes all unittests here and renders the page identically to the current version when run inside dev_appserver.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30330 lines, -83682 lines) Patch
M app.py View 12 chunks +359 lines, -301 lines 0 comments Download
M app_test.py View 6 chunks +95 lines, -108 lines 0 comments Download
M handler.py View 1 chunk +2 lines, -1 line 0 comments Download
D tests/test_console_merger/chromium_chrome_console_input.html View 1 chunk +0 lines, -2206 lines 0 comments Download
D tests/test_console_merger/chromium_chromiumos_console_input.html View 1 chunk +0 lines, -2992 lines 0 comments Download
D tests/test_console_merger/chromium_main_console_input.html View 1 chunk +0 lines, -10609 lines 0 comments Download
D tests/test_console_merger/chromium_memory_console_input.html View 1 chunk +0 lines, -1995 lines 0 comments Download
D tests/test_console_merger/chromium_merged_console.html View 1 chunk +0 lines, -11118 lines 0 comments Download
A tests/test_console_merger/latest_rev.txt View 1 chunk +1 line, -0 lines 0 comments Download
A tests/test_console_merger/linux_categories_input.html View 1 chunk +12 lines, -0 lines 0 comments Download
A tests/test_console_merger/linux_console_input.html View 1 chunk +3381 lines, -0 lines 0 comments Download
A tests/test_console_merger/linux_row_input.txt View 1 chunk +99 lines, -0 lines 0 comments Download
A tests/test_console_merger/linux_summary_input.html View 1 chunk +90 lines, -0 lines 0 comments Download
A + tests/test_console_merger/mac_categories_input.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/test_console_merger/mac_console_input.html View 1 chunk +3822 lines, -0 lines 0 comments Download
A tests/test_console_merger/mac_row_input.txt View 1 chunk +117 lines, -0 lines 0 comments Download
A tests/test_console_merger/mac_summary_input.html View 1 chunk +108 lines, -0 lines 0 comments Download
A tests/test_console_merger/memory_categories_input.html View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/test_console_merger/memory_console_input.html View 1 chunk +4067 lines, -0 lines 0 comments Download
A tests/test_console_merger/memory_row_input.txt View 1 chunk +128 lines, -0 lines 0 comments Download
A tests/test_console_merger/memory_summary_input.html View 1 chunk +119 lines, -0 lines 0 comments Download
A tests/test_console_merger/merged_console_output.html View 1 chunk +1500 lines, -0 lines 0 comments Download
A tests/test_console_merger/surroundings_input.html View 1 chunk +815 lines, -0 lines 0 comments Download
A + tests/test_console_merger/win_categories_input.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/test_console_merger/win_console_input.html View 1 chunk +5531 lines, -0 lines 0 comments Download
A tests/test_console_merger/win_row_input.txt View 1 chunk +182 lines, -0 lines 0 comments Download
A tests/test_console_merger/win_summary_input.html View 1 chunk +173 lines, -0 lines 0 comments Download
D tests/test_console_merger_splitrevs/chromium_chrome_console.html View 1 chunk +0 lines, -2216 lines 0 comments Download
D tests/test_console_merger_splitrevs/chromium_chromiumos_console.html View 1 chunk +0 lines, -3192 lines 0 comments Download
D tests/test_console_merger_splitrevs/chromium_console.html View 1 chunk +0 lines, -10614 lines 0 comments Download
D tests/test_console_merger_splitrevs/chromium_memory_console.html View 1 chunk +0 lines, -1956 lines 0 comments Download
D tests/test_console_merger_splitrevs/chromium_merged_console.html View 1 chunk +0 lines, -9499 lines 0 comments Download
A tests/test_console_merger_splitrevs/latest_rev.txt View 1 chunk +1 line, -0 lines 0 comments Download
A tests/test_console_merger_splitrevs/linux_categories_input.html View 1 chunk +12 lines, -0 lines 0 comments Download
A tests/test_console_merger_splitrevs/linux_console_input.html View 1 chunk +3381 lines, -0 lines 0 comments Download
A tests/test_console_merger_splitrevs/linux_row_input.txt View 1 chunk +99 lines, -0 lines 0 comments Download
A tests/test_console_merger_splitrevs/linux_summary_input.html View 1 chunk +90 lines, -0 lines 0 comments Download
A + tests/test_console_merger_splitrevs/mac_categories_input.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/test_console_merger_splitrevs/mac_console_input.html View 1 chunk +3822 lines, -0 lines 0 comments Download
A tests/test_console_merger_splitrevs/mac_row_input.txt View 1 chunk +117 lines, -0 lines 0 comments Download
A tests/test_console_merger_splitrevs/mac_summary_input.html View 1 chunk +108 lines, -0 lines 0 comments Download
A tests/test_console_merger_splitrevs/merged_console_output.html View 1 chunk +1264 lines, -0 lines 0 comments Download
A tests/test_console_merger_splitrevs/surroundings_input.html View 1 chunk +815 lines, -0 lines 0 comments Download
D tests/test_console_merger_utf8/chromium_chrome_console_input.html View 1 chunk +0 lines, -2241 lines 0 comments Download
D tests/test_console_merger_utf8/chromium_chromiumos_console_input.html View 1 chunk +0 lines, -3259 lines 0 comments Download
D tests/test_console_merger_utf8/chromium_main_console_input.html View 1 chunk +0 lines, -10638 lines 0 comments Download
D tests/test_console_merger_utf8/chromium_memory_console_input.html View 1 chunk +0 lines, -1974 lines 0 comments Download
D tests/test_console_merger_utf8/chromium_merged_console.html View 1 chunk +0 lines, -8749 lines 0 comments Download
M tests/test_parse_master/console-input.html View 2 chunks +0 lines, -2 lines 0 comments Download
tests/test_parse_master/console-input-handled.html View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/test_parse_master/expected-status.html View 5 chunks +5 lines, -13 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698