Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11530004: google_apis: DriveServiceInterface::GetResourceEntry() returns ResourceEntry (Closed)

Created:
8 years ago by satorux1
Modified:
8 years ago
Reviewers:
kinaba, tzik
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

google_apis: DriveServiceInterface::GetResourceEntry() returns ResourceEntry This way, client code doesn't have to convert base::Value to ResourceEntry BUG=165387 TEST=Drive works as before (i.e. if GetResourceEntry() is broken, Drive won't work at all) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172553

Patch Set 1 : polish #

Patch Set 2 : rebase #

Patch Set 3 : fix dcheck #

Patch Set 4 : fix unit_tests #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -117 lines) Patch
M chrome/browser/chromeos/drive/drive_api_service.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_api_service.cc View 1 2 3 4 3 chunks +35 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 1 2 3 4 9 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/drive_service_interface.h View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/google_apis/drive_uploader_unittest.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 1 2 3 4 2 chunks +29 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/mock_drive_service.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_client.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_client.cc View 1 2 3 4 8 chunks +10 lines, -21 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc View 1 2 3 4 16 chunks +58 lines, -35 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc View 1 2 3 4 4 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
tzik: sync_file_system kinaba: everything else
8 years ago (2012-12-11 07:46:28 UTC) #1
kinaba
lgtm
8 years ago (2012-12-11 08:25:54 UTC) #2
tzik
8 years ago (2012-12-12 04:28:06 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698