Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: chrome/browser/autofill/phone_number_i18n.h

Issue 11529004: [Autofill] Style cleanup in phone number-related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/phone_number.h ('k') | chrome/browser/autofill/phone_number_i18n.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/phone_number_i18n.h
diff --git a/chrome/browser/autofill/phone_number_i18n.h b/chrome/browser/autofill/phone_number_i18n.h
index 7b9a1408d91fe4fa84097a5c4abe9671c3bd3d42..5e40b11b9a4c403eeceea25c9ea98e36babdb795 100644
--- a/chrome/browser/autofill/phone_number_i18n.h
+++ b/chrome/browser/autofill/phone_number_i18n.h
@@ -29,13 +29,10 @@ namespace autofill_i18n {
string16 NormalizePhoneNumber(const string16& value,
const std::string& region);
-// Parses |value| to extract the components of a phone number. |number|
-// returns the local number, |city_code| returns the city code, and
-// |country_code| returns country code. For some regions the |city_code| is
-// empty.
-// The parsing is based on current region - |region|.
-// Separator characters are stripped before parsing the digits.
-// Returns true if parsing was successful, false otherwise.
+// Parses the number stored in |value| as a phone number interpreted in the
+// given |region|, and stores the results into the remaining arguments. The
+// |region| should be a 2-letter country code. This is an internal function,
+// exposed in the header file so that it can be tested.
bool ParsePhoneNumber(const string16& value,
const std::string& region,
string16* country_code,
@@ -51,7 +48,7 @@ enum FullPhoneFormat {
// Constructs whole phone number from parts.
// |city_code| - area code, could be empty.
-// |country_code| - country code, could be empty
+// |country_code| - country code, could be empty.
// |number| - local number, should not be empty.
// |region| - current region, the parsing is based on.
// |phone_format| - whole number constructed in that format,
@@ -65,6 +62,8 @@ bool ConstructPhoneNumber(const string16& country_code,
FullPhoneFormat phone_format,
string16* whole_number) WARN_UNUSED_RESULT;
+// Returns true if |number_a| and |number_b| parse to the same phone number in
+// the given |region|.
bool PhoneNumbersMatch(const string16& number_a,
const string16& number_b,
const std::string& region);
« no previous file with comments | « chrome/browser/autofill/phone_number.h ('k') | chrome/browser/autofill/phone_number_i18n.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698