Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Issue 11529003: [cc] Route LayerImpl::layerTreeHostImpl() calls through LayerTreeImpl (Closed)

Created:
8 years ago by nduca
Modified:
8 years ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Route LayerImpl::layerTreeHostImpl() calls through LayerTreeImpl Pulled settings & debugstate to their own files to reduce header coupling, which bit me a few times on this patch [lthi needs lth, lti needs lthi for settings, etc]. NOTRY=true BUG=155209 R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172635

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : now with <limits> #

Patch Set 4 : using struct #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -249 lines) Patch
M cc/cc.gyp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M cc/debug_colors.h View 1 chunk +17 lines, -17 lines 0 comments Download
M cc/debug_colors.cc View 2 chunks +19 lines, -19 lines 0 comments Download
M cc/debug_rect_history.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 5 chunks +14 lines, -13 lines 0 comments Download
M cc/io_surface_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layer_impl.cc View 13 chunks +18 lines, -21 lines 0 comments Download
A cc/layer_tree_debug_state.h View 1 chunk +39 lines, -0 lines 0 comments Download
A cc/layer_tree_debug_state.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M cc/layer_tree_host.h View 2 chunks +1 line, -46 lines 0 comments Download
M cc/layer_tree_host.cc View 1 2 3 4 1 chunk +0 lines, -108 lines 0 comments Download
M cc/layer_tree_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_impl.h View 2 chunks +28 lines, -4 lines 0 comments Download
M cc/layer_tree_impl.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A cc/layer_tree_settings.h View 1 chunk +41 lines, -0 lines 0 comments Download
A cc/layer_tree_settings.cc View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
M cc/picture_layer_impl.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M cc/quad_culler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/render_surface_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/video_layer_impl.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nduca
This is a followup to https://codereview.chromium.org/11519018/. I can squash this onto the previous, open to ...
8 years ago (2012-12-11 07:04:46 UTC) #1
enne (OOO)
Reduction in coupling lgtm.
8 years ago (2012-12-11 16:59:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11529003/1
8 years ago (2012-12-12 00:12:25 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-12 00:37:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11529003/5004
8 years ago (2012-12-12 18:13:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
8 years ago (2012-12-12 19:10:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11529003/5004
8 years ago (2012-12-12 19:18:08 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-12 19:18:38 UTC) #8
Message was sent while issue was closed.
Change committed as 172635

Powered by Google App Engine
This is Rietveld 408576698