Simple memory testing for gae/wrapper

go/src/infra/gae/libs/meta/eg_test.go

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package meta
+
+import (
+        "testing"
+
+        "golang.org/x/net/context"
+
+        "infra/gae/libs/wrapper"
+        "infra/gae/libs/wrapper/memory"
+
+        . "github.com/smartystreets/goconvey/convey"
+)
+
+func TestGetEntityGroupVersion(t *testing.T) {

[M-A Ruel, 2015/05/27 20:14:47]

Why none of your tests are t.Parallel()?

[iannucci, 2015/05/27 21:36:22]

because the entire test suite takes .1 seconds and I wasn't worrying about it?

changed them all to Parallel. Now they take .1 seconds instead of .1 seconds.

\o/

[M-A Ruel, 2015/05/28 22:42:38]

There's two reasons;
- With Convey(), you make large test cases.
- You need to set GOMAXPROCS manually in an init() function.

It's more a statement to make it clear that there is no global context.

[iannucci, 2015/05/28 23:00:34]

Oh, that reminds me. I have half of a patch to convey to make them
auto-parallelize that I never committed. I should finish that.
getting fixed in go 1.5!!! woohoo!!
yep, very good point. Will add this to my default mental boilerplate.

+        Convey("GetEntityGroupVersion", t, func() {
+                c := memory.Use(memory.Enable(context.Background()))
+                ds := wrapper.GetDS(c)
+
+                type A struct {

[M-A Ruel, 2015/05/27 20:14:47]

a := &struct {
...
}{Val:10}

would work fine. You do not need to export the structure itself, just the
members.

In fact, you don't even need the named variable a but inlining it at the
ds.Put() call that would make the code a bit opaque.

[iannucci, 2015/05/27 21:36:22]

Put uses reflection to discover the type name. An anonymous type wouldn't work
(though I could add an explicit 'kind' field to skip the reflection).

+                        ID  int64 `datastore:"-" goon:"id"`
+                        Val int
+                }
+
+                a := &A{Val: 10}
+                aKey, err := ds.Put(a)
+                So(err, ShouldBeNil)
+
+                v, err := GetEntityGroupVersion(c, aKey)
+                So(err, ShouldBeNil)
+                So(v, ShouldEqual, 1)
+
+                So(ds.Delete(aKey), ShouldBeNil)
+
+                v, err = GetEntityGroupVersion(c, ds.NewKey("madeUp", "thing", 0, aKey))
+                So(err, ShouldBeNil)
+                So(v, ShouldEqual, 2)
+
+                v, err = GetEntityGroupVersion(c, ds.NewKey("madeUp", "thing", 0, nil))
+                So(err, ShouldBeNil)
+                So(v, ShouldEqual, 0)
+
+                tDs := ds.(wrapper.Testable)
+                tDs.BreakFeatures(nil, "Get")
+
+                v, err = GetEntityGroupVersion(c, aKey)
+                So(err.Error(), ShouldContainSubstring, "INTERNAL_ERROR")
+        })
+}