Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

Issue 11522009: X-Chrome-Variations logic refactoring (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Merged with head. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h
index 22e66b80f0202a45039a5e241d5d1be19d452750..6931431b0c27975814fb1dc88173f88aa3af15e8 100644
--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h
@@ -9,8 +9,6 @@
#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
-#include "base/metrics/field_trial.h"
-#include "chrome/common/metrics/variations/variation_ids.h"
#include "content/public/browser/resource_dispatcher_host_delegate.h"
class DelayedResourceQueue;
@@ -28,8 +26,7 @@ class PrerenderTracker;
// Implements ResourceDispatcherHostDelegate. Currently used by the Prerender
// system to abort requests and add to the load flags when a request begins.
class ChromeResourceDispatcherHostDelegate
- : public content::ResourceDispatcherHostDelegate,
- public base::FieldTrialList::Observer {
+ : public content::ResourceDispatcherHostDelegate {
public:
// This class does not take ownership of the tracker but merely holds a
// reference to it to avoid accessing g_browser_process.
@@ -87,13 +84,6 @@ class ChromeResourceDispatcherHostDelegate
content::ResourceContext* resource_context,
content::ResourceResponse* response) OVERRIDE;
- // base::FieldTrialList::Observer implementation.
- // This will add the variation ID associated with |trial_name| and
- // |group_name| to the variation ID cache.
- virtual void OnFieldTrialGroupFinalized(
- const std::string& trial_name,
- const std::string& group_name) OVERRIDE;
-
private:
void AppendStandardResourceThrottles(
net::URLRequest* request,
@@ -119,30 +109,11 @@ class ChromeResourceDispatcherHostDelegate
content::ResourceContext* resource_context);
#endif
- // Prepares the variation IDs cache with initial values if not already done.
- // This method also registers the caller with the FieldTrialList to receive
- // new variation IDs.
- void InitVariationIDsCacheIfNeeded();
-
- // Takes whatever is currently in |variation_ids_set_| and recreates
- // |variation_ids_header_| with it.
- void UpdateVariationIDsHeaderValue();
-
scoped_refptr<DownloadRequestLimiter> download_request_limiter_;
scoped_refptr<SafeBrowsingService> safe_browsing_;
scoped_refptr<extensions::UserScriptListener> user_script_listener_;
prerender::PrerenderTracker* prerender_tracker_;
- // Whether or not we've initialized the Cache.
- bool variation_ids_cache_initialized_;
-
- // Keep a cache of variation IDs that are transmitted in headers to Google.
- // This consists of a list of valid IDs, and the actual transmitted header.
- // Note that since this cache is both initialized and accessed from the IO
- // thread, we do not need to synchronize its uses.
- std::set<chrome_variations::VariationID> variation_ids_set_;
- std::string variation_ids_header_;
-
DISALLOW_COPY_AND_ASSIGN(ChromeResourceDispatcherHostDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698