Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 11522007: Move TopSites api from c/b/history to c/b/e/api (Closed)

Created:
8 years ago by Devlin
Modified:
8 years ago
Reviewers:
Matt Perry, sky
CC:
chromium-reviews, Aaron Boodman, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@dc_ungoop_history
Visibility:
Public.

Description

Move TopSites api from c/b/history to c/b/e/api Move the TopSites extension API out of c/b/history and into c/b/e/api with all the other APIs. Remove the c/b/extensions/ dependencies completely from c/b/history. BUG=101244 TBR=ben@chromium.org for gypi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173575

Patch Set 1 #

Patch Set 2 : Latest master #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -154 lines) Patch
A + chrome/browser/extensions/api/top_sites/top_sites_api.h View 2 chunks +7 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/top_sites/top_sites_api.cc View 3 chunks +5 lines, -1 line 0 comments Download
A + chrome/browser/extensions/api/top_sites/top_sites_apitest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/history/top_sites_extension_api.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/history/top_sites_extension_api.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/history/top_sites_extension_test.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
8 years ago (2012-12-10 23:54:51 UTC) #1
Matt Perry
lgtm
8 years ago (2012-12-11 00:18:32 UTC) #2
Devlin
+sky for c/b/history/
8 years ago (2012-12-17 17:22:19 UTC) #3
sky
LGTM
8 years ago (2012-12-17 17:41:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/11522007/6001
8 years ago (2012-12-17 17:44:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-17 20:10:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/11522007/6001
8 years ago (2012-12-17 20:20:33 UTC) #7
commit-bot: I haz the power
Change committed as 173575
8 years ago (2012-12-17 23:50:26 UTC) #8
Yoyo Zhou
8 years ago (2012-12-17 23:59:29 UTC) #9
Message was sent while issue was closed.
Drive-by comment: if the CL description is correct, some exceptions in
chrome/browser/history/DEPS can now be removed. There should be no more api or
extension tests and no extension_function references.

Powered by Google App Engine
This is Rietveld 408576698