Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 11519045: Remove unused gpu message fields. (Closed)

Created:
8 years ago by no sievers
Modified:
8 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, alexst (slow to review)
Visibility:
Public.

Description

Remove unused gpu message fields. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173029

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Messages

Total messages: 9 (0 generated)
no sievers
All Mac-specific fields as well as width/height in the SurfaceNew seem unused nowadays. But maybe ...
8 years ago (2012-12-12 23:17:15 UTC) #1
no sievers
On 2012/12/12 23:17:15, Daniel Sievers wrote: > All Mac-specific fields as well as width/height in ...
8 years ago (2012-12-12 23:55:32 UTC) #2
piman
LGTM You'll need a security person to look at the message changes.
8 years ago (2012-12-13 00:00:38 UTC) #3
no sievers
+cevans for security review of gpu_messages.h
8 years ago (2012-12-13 00:04:58 UTC) #4
Chris Evans
On 2012/12/13 00:04:58, Daniel Sievers wrote: > +cevans for security review of gpu_messages.h LGTM!
8 years ago (2012-12-13 00:11:03 UTC) #5
jonathan.backer
https://codereview.chromium.org/11519045/diff/9002/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/11519045/diff/9002/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode985 content/browser/renderer_host/render_widget_host_view_aura.cc:985: gfx::Size(0, 0), device_scale_factor_, Do we still need the size? ...
8 years ago (2012-12-13 14:21:58 UTC) #6
no sievers
On 2012/12/13 14:21:58, jonathan.backer wrote: > https://codereview.chromium.org/11519045/diff/9002/content/browser/renderer_host/render_widget_host_view_aura.cc > File content/browser/renderer_host/render_widget_host_view_aura.cc (right): > > https://codereview.chromium.org/11519045/diff/9002/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode985 > ...
8 years ago (2012-12-13 21:44:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/11519045/14001
8 years ago (2012-12-13 21:45:13 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-14 01:11:20 UTC) #9
Message was sent while issue was closed.
Change committed as 173029

Powered by Google App Engine
This is Rietveld 408576698