A11y: Add a browser test of TrayAccessibility.

A11y: Add a browser test of TrayAccessibility.

BUG=164766
TEST=browser_test passes

R=stevenjb@chromium.org, zork@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173389

[yoshiki, 2012-12-12 16:06:26]

@zork, @stevenjb: could you take a look?

@stevenjb: ash/system/*
@zork: 	 chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

[stevenjb, 2012-12-14 00:38:27]

Didn't look too closely at the test itself, but generally LGTM

https://codereview.chromium.org/11519036/diff/3001/ash/system/tray/system_tray.h
File ash/system/tray/system_tray.h (right):

https://codereview.chromium.org/11519036/diff/3001/ash/system/tray/system_tra...
ash/system/tray/system_tray.h:212: internal::TrayAccessibility*
tray_accessibility_;  // not own
nit: 'not owned' or 'unowned'

https://codereview.chromium.org/11519036/diff/3001/ash/system/tray_accessibil...
File ash/system/tray_accessibility.h (right):

https://codereview.chromium.org/11519036/diff/3001/ash/system/tray_accessibil...
ash/system/tray_accessibility.h:37: namespace tray{
nit: ' ' before {

[yoshiki, 2012-12-14 06:10:19]

Thanks!

https://codereview.chromium.org/11519036/diff/3001/ash/system/tray/system_tray.h
File ash/system/tray/system_tray.h (right):

https://codereview.chromium.org/11519036/diff/3001/ash/system/tray/system_tra...
ash/system/tray/system_tray.h:212: internal::TrayAccessibility*
tray_accessibility_;  // not own
On 2012/12/14 00:38:28, stevenjb (chromium) wrote:
> nit: 'not owned' or 'unowned'

Done.

https://codereview.chromium.org/11519036/diff/3001/ash/system/tray_accessibil...
File ash/system/tray_accessibility.h (right):

https://codereview.chromium.org/11519036/diff/3001/ash/system/tray_accessibil...
ash/system/tray_accessibility.h:37: namespace tray{
On 2012/12/14 00:38:28, stevenjb (chromium) wrote:
> nit: ' ' before {

Done.

[commit-bot: I haz the power, 2012-12-14 06:12:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11519036/10001

[commit-bot: I haz the power, 2012-12-14 06:45:37]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-14 15:14:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11519036/16004

[commit-bot: I haz the power, 2012-12-14 15:48:26]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-14 18:53:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11519036/16004

[commit-bot: I haz the power, 2012-12-15 01:14:25]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-15 02:37:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11519036/16004

[commit-bot: I haz the power, 2012-12-15 07:03:58]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-15 07:13:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11519036/16004

[commit-bot: I haz the power, 2012-12-15 11:36:58]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-16 17:15:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11519036/26001

[commit-bot: I haz the power, 2012-12-16 20:31:27]

Change committed as 173389