base: Do not use Value::Create* functions.

base: Do not use Value::Create* functions.

BUG=160586
R=willchan@chromium.org,estade@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173368

[tfarina, 2012-12-12 03:33:51]

Hi Will, could you review this to me?

Evan, fyi.

Thanks,

[willchan no longer on Chromium, 2012-12-12 21:17:31]

Evan, it seems like you're driving this effort. I skimmed it to confirm there
isn't any major API or internals change here. Can you do the detailed review? If
it's fine by you too, then I'll rubberstamp.

[Evan Stade, 2012-12-13 00:44:00]

https://codereview.chromium.org/11519026/diff/5023/base/values_unittest.cc
File base/values_unittest.cc (right):

https://codereview.chromium.org/11519026/diff/5023/base/values_unittest.cc#ne...
base/values_unittest.cc:99: scoped_ptr<Value> not_found_value(new
FundamentalValue(false));
dont' need these scoped_ptrs

[tfarina, 2012-12-13 16:11:39]

https://codereview.chromium.org/11519026/diff/5023/base/values_unittest.cc
File base/values_unittest.cc (right):

https://codereview.chromium.org/11519026/diff/5023/base/values_unittest.cc#ne...
base/values_unittest.cc:99: scoped_ptr<Value> not_found_value(new
FundamentalValue(false));
On 2012/12/13 00:44:00, Evan Stade wrote:
> dont' need these scoped_ptrs

Done.

[Evan Stade, 2012-12-13 20:33:21]

lgtm

[willchan no longer on Chromium, 2012-12-13 20:35:00]

lgtm

[commit-bot: I haz the power, 2012-12-16 00:23:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/11519026/14001

[commit-bot: I haz the power, 2012-12-16 01:42:20]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-16 01:44:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/11519026/14001

[commit-bot: I haz the power, 2012-12-16 05:13:22]

Change committed as 173368