Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11519018: [cc] Make LayerImpls point at LayerTreeImpl instead of LTHI (Closed)

Created:
8 years ago by nduca
Modified:
8 years ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Make LayerImpls point at LayerTreeImpl instead of LTHI BUG=155209 R=enne@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172411

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -442 lines) Patch
M cc/damage_tracker_unittest.cc View 14 chunks +19 lines, -19 lines 0 comments Download
M cc/delegated_renderer_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/delegated_renderer_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/delegated_renderer_layer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/delegated_renderer_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/delegated_renderer_layer_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M cc/gl_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/heads_up_display_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/heads_up_display_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/heads_up_display_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/io_surface_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/io_surface_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/io_surface_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/io_surface_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layer.h View 2 chunks +2 lines, -2 lines 1 comment Download
M cc/layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layer_impl.h View 5 chunks +7 lines, -5 lines 0 comments Download
M cc/layer_impl.cc View 13 chunks +21 lines, -16 lines 0 comments Download
M cc/layer_impl_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M cc/layer_sorter_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M cc/layer_tree_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 26 chunks +40 lines, -40 lines 0 comments Download
M cc/layer_tree_host_impl.h View 5 chunks +6 lines, -7 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 64 chunks +105 lines, -104 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M cc/layer_tree_impl.h View 2 chunks +11 lines, -12 lines 0 comments Download
M cc/layer_tree_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/nine_patch_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/nine_patch_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/nine_patch_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/nine_patch_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/nine_patch_layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/occlusion_tracker_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/picture_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/picture_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/picture_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/picture_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/quad_culler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/render_surface_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/scrollbar_animation_controller_linear_fade_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/scrollbar_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scrollbar_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scrollbar_layer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scrollbar_layer_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/scrollbar_layer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/solid_color_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/solid_color_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/solid_color_layer_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/solid_color_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/solid_color_layer_impl_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/test/tiled_layer_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/tiled_layer_test_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/texture_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/texture_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/texture_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/texture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiled_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/tiled_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiled_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer_unittest.cc View 26 chunks +36 lines, -36 lines 0 comments Download
M cc/tree_synchronizer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/tree_synchronizer.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M cc/tree_synchronizer_unittest.cc View 15 chunks +41 lines, -41 lines 0 comments Download
M cc/video_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/video_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/video_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/video_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nduca
ptal
8 years ago (2012-12-11 05:52:32 UTC) #1
enne (OOO)
lgtm https://codereview.chromium.org/11519018/diff/1/cc/layer.h File cc/layer.h (right): https://codereview.chromium.org/11519018/diff/1/cc/layer.h#newcode316 cc/layer.h:316: virtual scoped_ptr<LayerImpl> createLayerImpl(LayerTreeImpl* treeImpl); Sad times all around. ...
8 years ago (2012-12-11 16:50:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11519018/1
8 years ago (2012-12-11 16:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11519018/1
8 years ago (2012-12-11 20:36:34 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-11 21:38:11 UTC) #5
Message was sent while issue was closed. 
Change committed as 172411

Powered by Google App Engine
This is Rietveld 408576698