Issue 11517014: TextureImageTransport: Remove some debug code in OnMakeCurrent().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11517014: TextureImageTransport: Remove some debug code in OnMakeCurrent(). (Closed)

Created:
8 years ago by no sievers

Modified:
8 years ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, aelias_OOO_until_Jul13, klobag

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

TextureImageTransport: Remove some debug code in OnMakeCurrent(). This check is mostly redundant with the check for framebuffer completeness already performed from CreateBackTexture()->AttachBackTextureToFBO(). The only thing that's different is that the above uses a scoped fbo binding (to the correct fbo), which means that the additional check being removed here was actually verifying potentially invalid assumptions about the original FBO binding at the time OnMakeCurrent() is called. For example, with virtual contexts we restore the binding *after* calling GLSurface::OnMakeCurrent(). BUG=160710 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172214

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	content/common/gpu/texture_image_transport_surface.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/11517014/1

8 years ago (2012-12-11 00:48:19 UTC) #3

Message was sent while issue was closed.

Change committed as 172214

Expand Messages | Collapse Messages