Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 11516022: cc: Resize picture layer tiling set during commit (Closed)

Created:
8 years ago by enne (OOO)
Modified:
8 years ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org, aelias_OOO_until_Jul13
Visibility:
Public.

Description

cc: Resize picture layer tiling set during commit Previously, we would only set the tiling set bounds post-calcDraw, which means that invalidations that came in during the commit would get dropped because they were outside the content bounds of each tiling. Fix this by explicitly updating bounds during the commit prior to invalidation. This fixes offscreen garbage caused by layer resizing when viewing a directory with impl-side painting. The didUpdateBounds function is in line with the direction of the patch here: https://codereview.chromium.org/11503005/ and can just be made virtual in the future. R=nduca@chromium.org BUG=165246 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M cc/picture_layer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/picture_layer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/picture_layer_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M cc/picture_layer_tiling_set.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
8 years ago (2012-12-11 01:38:10 UTC) #1
enne (OOO)
There's still some additional wonkiness going on with invalidation and this doesn't fix all the ...
8 years ago (2012-12-11 01:38:47 UTC) #2
nduca
lgtm
8 years ago (2012-12-11 02:52:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11516022/1
8 years ago (2012-12-11 17:35:45 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-11 19:29:33 UTC) #5
Message was sent while issue was closed.
Change committed as 172372

Powered by Google App Engine
This is Rietveld 408576698