Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11516020: Refactor PPB_Flash GetLocalTimeZoneOffset to the new PPAPI resource model (Closed)

Created:
8 years ago by raymes
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

This refactors PPB_Flash GetLocalTimeZoneOffset to the new PPAPI resource model. The in process implementation is removed. Associated plugin delegate code is also removed. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173578

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -156 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_browser_host.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_browser_host.cc View 1 2 3 3 chunks +15 lines, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_message_filter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_message_filter.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/proxy/flash_resource.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/proxy/flash_resource.cc View 1 2 3 4 2 chunks +72 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 6 chunks +0 lines, -88 lines 0 comments Download
M ppapi/shared_impl/time_conversion.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/shared_impl/time_conversion.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_flash_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_flash_functions_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_flash_thunk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
raymes
8 years ago (2012-12-11 19:25:12 UTC) #1
Scott Hess - ex-Googler
lgtm overall, with the quibble on 0.0. https://codereview.chromium.org/11516020/diff/11003/ppapi/proxy/flash_resource.cc File ppapi/proxy/flash_resource.cc (right): https://codereview.chromium.org/11516020/diff/11003/ppapi/proxy/flash_resource.cc#newcode118 ppapi/proxy/flash_resource.cc:118: t = ...
8 years ago (2012-12-12 23:19:15 UTC) #2
raymes
+yzshen for OWNERS https://codereview.chromium.org/11516020/diff/11003/ppapi/proxy/flash_resource.cc File ppapi/proxy/flash_resource.cc (right): https://codereview.chromium.org/11516020/diff/11003/ppapi/proxy/flash_resource.cc#newcode118 ppapi/proxy/flash_resource.cc:118: t = 0.0000000001; I fixed this ...
8 years ago (2012-12-13 18:24:54 UTC) #3
Scott Hess - ex-Googler
still lgtm
8 years ago (2012-12-13 18:36:45 UTC) #4
yzshen1
lgtm
8 years ago (2012-12-13 20:01:13 UTC) #5
raymes
+tsepez for ppapi_messages
8 years ago (2012-12-17 20:26:20 UTC) #6
Tom Sepez
Rubberstamp LGTM on ppapi_messages.h based upon timezone messages not being scary.
8 years ago (2012-12-17 20:43:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/11516020/19001
8 years ago (2012-12-17 20:53:25 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-17 23:51:24 UTC) #9
Message was sent while issue was closed. 
Change committed as 173578

Powered by Google App Engine
This is Rietveld 408576698