Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11516010: Move BookmarkManagerAPI to c/b/e/api (Closed)

Created:
8 years ago by Devlin
Modified:
8 years ago
Reviewers:
Yoyo Zhou, brettw
CC:
chromium-reviews, Aaron Boodman, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@dc_ungoop4
Visibility:
Public.

Description

Move BookmarkManagerAPI to c/b/e/api Remove the BookmarkManagerAPI from c/b/bookmarks, and remove the last of the c/b/extensions/ files from the bookmarks/ DEPS. BUG=101244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174018

Patch Set 1 #

Patch Set 2 : s/bookmark_manager/bookmark_manager_private #

Total comments: 6

Patch Set 3 : Yoyo's requests #

Patch Set 4 : Latest master #

Patch Set 5 : #

Patch Set 6 : Latest master #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -892 lines) Patch
M chrome/browser/bookmarks/DEPS View 1 2 3 4 5 3 chunks +0 lines, -10 lines 0 comments Download
D chrome/browser/bookmarks/bookmark_manager_extension_api.h View 1 chunk +0 lines, -199 lines 0 comments Download
D chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 2 3 4 5 1 chunk +0 lines, -529 lines 0 comments Download
D chrome/browser/bookmarks/bookmark_manager_extension_apitest.cc View 1 2 3 4 1 chunk +0 lines, -52 lines 0 comments Download
A + chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h View 1 2 3 4 4 chunks +11 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 2 3 4 5 17 chunks +47 lines, -49 lines 0 comments Download
A chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api_constants.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api_constants.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_constants.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 2 3 4 5 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.h View 1 2 3 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Devlin
8 years ago (2012-12-10 21:49:45 UTC) #1
Yoyo Zhou
The directory should match the API namespace, so it should be bookmark_manager_private.
8 years ago (2012-12-10 21:54:45 UTC) #2
Devlin
On 2012/12/10 21:54:45, Yoyo Zhou wrote: > The directory should match the API namespace, so ...
8 years ago (2012-12-10 22:14:20 UTC) #3
Yoyo Zhou
LGTM https://codereview.chromium.org/11516010/diff/3002/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h File chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h (right): https://codereview.chromium.org/11516010/diff/3002/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h#newcode24 chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h:24: class BookmarkManagerEventRouter : public BookmarkTabHelper::BookmarkDrag { Should also ...
8 years ago (2012-12-10 22:35:09 UTC) #4
Devlin
https://codereview.chromium.org/11516010/diff/3002/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h File chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h (right): https://codereview.chromium.org/11516010/diff/3002/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h#newcode24 chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h:24: class BookmarkManagerEventRouter : public BookmarkTabHelper::BookmarkDrag { On 2012/12/10 22:35:10, ...
8 years ago (2012-12-10 22:55:04 UTC) #5
Devlin
+ brettw for c/b/bookmarks
8 years ago (2012-12-14 16:58:11 UTC) #6
Devlin
Brett, would you mind taking a look at c/b/bookmarks?
8 years ago (2012-12-17 17:18:07 UTC) #7
brettw
owners lgtm rubberstamp
8 years ago (2012-12-17 22:57:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/11516010/34001
8 years ago (2012-12-18 22:34:51 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years ago (2012-12-18 23:20:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/11516010/41002
8 years ago (2012-12-19 18:54:06 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests
8 years ago (2012-12-19 20:58:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/11516010/41002
8 years ago (2012-12-19 21:10:44 UTC) #13
commit-bot: I haz the power
8 years ago (2012-12-19 22:25:26 UTC) #14
Message was sent while issue was closed. 
Change committed as 174018

Powered by Google App Engine
This is Rietveld 408576698