Switch the Linux bots on chromium.webkit to use Ninja.

Switch the Linux bots on chromium.webkit to use Ninja.

Since we're planning on changing the upstream build.webkit.org bots
to Ninja, change these too. https://bugs.webkit.org/show_bug.cgi?id=104434
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172342

[tony, 2012-12-10 21:43:51]

I verified that the master starts locally and connected a slave to the master
for WebKit Linux.  The bot successfully compiled with ninja and ran the tests.

This change depends on https://codereview.chromium.org/11511007/ .

[cmp, 2012-12-10 21:59:35]

Thanks Tony.  Asking Robbie to take a look at this CL since it's related to
switching bots to Ninja on the chromium.webkit waterfall.

[iannucci, 2012-12-10 22:08:15]

lgtm :)

https://codereview.chromium.org/11516008/diff/1/masters/master.chromium.webki...
File masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py (right):

https://codereview.chromium.org/11516008/diff/1/masters/master.chromium.webki...
masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py:49:
'chromium_gpu_builder',
Not to be pedantic, but I think we're trying to converge on a '--' between
options and build targets :)

[tony, 2012-12-10 22:15:17]

Thanks!

https://codereview.chromium.org/11516008/diff/1/masters/master.chromium.webki...
File masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py (right):

https://codereview.chromium.org/11516008/diff/1/masters/master.chromium.webki...
masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py:49:
'chromium_gpu_builder',
On 2012/12/10 22:08:15, iannucci wrote:
> Not to be pedantic, but I think we're trying to converge on a '--' between
> options and build targets :)

Ok, I've added '--' before any build targets.

[iannucci, 2012-12-10 22:33:07]

https://codereview.chromium.org/11516008/diff/6001/masters/master.chromium.we...
File masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py (right):

https://codereview.chromium.org/11516008/diff/6001/masters/master.chromium.we...
masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py:54:
'generate_gtest_json': True,
Oops... didn't catch this the first time around. All these indentations in
brackets should be +4 (though, I realize that some of the rest of this file is
doing it wrong and you were trying to be consistent :).

[tony, 2012-12-10 22:37:59]

https://codereview.chromium.org/11516008/diff/6001/masters/master.chromium.we...
File masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py (right):

https://codereview.chromium.org/11516008/diff/6001/masters/master.chromium.we...
masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py:54:
'generate_gtest_json': True,
On 2012/12/10 22:33:07, iannucci wrote:
> Oops... didn't catch this the first time around. All these indentations in
> brackets should be +4 (though, I realize that some of the rest of this file is
> doing it wrong and you were trying to be consistent :).

Fixed in patchset 3.

[iannucci, 2012-12-10 22:41:04]

Thanks, lgtm.

[iannucci, 2012-12-11 01:24:56]

On 2012/12/10 22:41:04, iannucci wrote:
> Thanks, lgtm.

+cmp: owner lgtm

You'll also need to get an lgtm from an owner, too.

[iannucci, 2012-12-11 01:25:24]

On 2012/12/11 01:24:56, iannucci wrote:
> On 2012/12/10 22:41:04, iannucci wrote:
> > Thanks, lgtm.
> 
> +cmp: owner lgtm
> 
> You'll also need to get an lgtm from an owner, too.

actually +cmp.

[cmp, 2012-12-11 01:26:22]

lgtm