Delay updating jumplist to avoid blocking the file thread at start-up

chrome/browser/jumplist_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/jumplist_win.h"
 
 #include <windows.h>
 #include <shobjidl.h>
 #include <propkey.h>
 #include <propvarutil.h>
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/threading/thread.h"
+#include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/windows_version.h"
 #include "chrome/browser/favicon/favicon_service.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/page_usage_data.h"
 #include "chrome/browser/history/top_sites.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/session_types.h"
@@ skipping 449 matching lines @@
     return false;
 
   return true;
 }
 
 }  // namespace
 
 JumpList::JumpList()
     : ALLOW_THIS_IN_INITIALIZER_LIST(weak_ptr_factory_(this)),
       profile_(NULL),
-      task_id_(CancelableTaskTracker::kBadTaskId) {
+      task_id_(CancelableTaskTracker::kBadTaskId),
+      status_(UPDATE_NOT_RUN) {
 }
 
 JumpList::~JumpList() {
   Terminate();
 }
 
 // static
 bool JumpList::Enabled() {
   return (base::win::GetVersion() >= base::win::VERSION_WIN7 &&
           !CommandLine::ForCurrentProcess()->HasSwitch(
@@ skipping 186 matching lines @@
   }
 }
 
 void JumpList::StartLoadingFavicon() {
   GURL url;
   {
     base::AutoLock auto_lock(list_lock_);
     if (icon_urls_.empty()) {
       // No more favicons are needed by the application JumpList. Schedule a
       // RunUpdate call.
-      BrowserThread::PostTask(
-          BrowserThread::FILE, FROM_HERE,
-          base::Bind(&JumpList::RunUpdate, this));
+      switch (status_) {
+        case UPDATE_NOT_RUN:
+          BrowserThread::PostDelayedTask(
+            BrowserThread::FILE, FROM_HERE,
+            base::Bind(&JumpList::RunUpdate, this),
+            base::TimeDelta::FromSeconds(15));

[jeremy, 2012/12/11 14:57:22]

Some startups are longer than 15 seconds, in other places in the code we've used
NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME to trigger tasks like this.

[Cait (Slow), 2012/12/11 15:37:44]

In this case, would NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME be used to determine
when the initial page was loaded (i.e. start-up was complete) and then ignored
afterwards, or would we delay updating the jumplist whenever a load was in
progress?

[jeremy, 2012/12/11 16:50:02]

Only for telling when startup is complete, thanks!

[Cait (Slow), 2012/12/11 20:54:34]

Done.

+          status_ = UPDATE_PENDING;
+          break;
+        case UPDATE_PENDING:
+          break;
+        case NONE_PENDING:
+          BrowserThread::PostTask(
+            BrowserThread::FILE, FROM_HERE,
+            base::Bind(&JumpList::RunUpdate, this));
+          break;
+      }
+
       return;
     }
     // Ask FaviconService if it has a favicon of a URL.
     // When FaviconService has one, it will call OnFaviconDataAvailable().
     url = GURL(icon_urls_.front().first);
   }
   FaviconService* favicon_service =
       FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
   task_id_ = favicon_service->GetFaviconImageForURL(
       FaviconService::FaviconForURLParams(profile_,
@@ skipping 26 matching lines @@
   // Check whether we need to load more favicons.
   StartLoadingFavicon();
 }
 
 void JumpList::RunUpdate() {
   ShellLinkItemList local_most_visited_pages;
   ShellLinkItemList local_recently_closed_pages;
 
   {
     base::AutoLock auto_lock(list_lock_);
+    status_ = NONE_PENDING;
     // Make sure we are not out of date: if icon_urls_ is not empty, then
     // another notification has been received since we processed this one
     if (!icon_urls_.empty())
       return;
 
     // Make local copies of lists so we can release the lock.
     local_most_visited_pages = most_visited_pages_;
     local_recently_closed_pages = recently_closed_pages_;
   }
 
@@ skipping 21 matching lines @@
 }
 
 void JumpList::CreateIconFiles(const ShellLinkItemList& item_list) {
   for (ShellLinkItemList::const_iterator item = item_list.begin();
       item != item_list.end(); ++item) {
     FilePath icon_path;
     if (CreateIconFile((*item)->data(), icon_dir_, &icon_path))
       (*item)->SetIcon(icon_path.value(), 0, true);
   }
 }