[cros] RLZ tracking can be turned off via a flag file.

chrome/browser/chromeos/chrome_browser_main_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/chrome_browser_main_chromeos.h"
 
 #include <string>
 #include <vector>
 
 #include "ash/shell.h"
@@ skipping 52 matching lines @@
 #include "chrome/browser/chromeos/upgrade_detector_chromeos.h"
 #include "chrome/browser/chromeos/web_socket_proxy_controller.h"
 #include "chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/metrics/metrics_service.h"
 #include "chrome/browser/net/chrome_network_delegate.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/rlz/rlz.h"
 #include "chrome/browser/signin/token_service_factory.h"
 #include "chrome/browser/system_monitor/removable_device_notifications_chromeos.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/logging_chrome.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/cryptohome/async_method_caller.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
@@ skipping 406 matching lines @@
   // Initialize magnification manager before ash tray is created. And this must
   // be placed after UserManager::SessionStarted();
   chromeos::MagnificationManager::Initialize();
 
 #if defined(USE_LINUX_BREAKPAD)
   cros_version_loader_.GetVersion(VersionLoader::VERSION_FULL,
                                   base::Bind(&ChromeOSVersionCallback),
                                   &tracker_);
 #endif
 
+#if defined(ENABLE_RLZ)
+  if (parsed_command_line().HasSwitch(::switches::kTestType))
+    RLZTracker::EnableZeroDelayForTesting();

[Peter Kasting, 2012/12/17 20:14:03]

Must we call this here?  Can we instead enable in individual tests that care, as
you've already done elsewhere in this CL?

[Ivan Korotkov, 2012/12/20 09:20:42]

I'd like to leave it here (like WizardController::SetZeroDelays in
PostProfileInit) because otherwise any browser test that uses real LoginUtils
and calls GetBlockingPool()->FlushForTesting() will be slowed down by 20 seconds
without an obvious reason.
login_utils_browsertest doesn't go through this path (it's not a real
InProcessBrowserTest, despite it's name), so a separate call is needed there.

[Peter Kasting, 2012/12/20 19:32:00]

Then can we make one of the following happen instead:
* In testing mode, the RLZ tracker _always_ runs in zero-delay mode (i.e. we do
this check in the RLZ code itself).
* In testing mode, the RLZ tracker doesn't do anything at all unless you
explicitly enable it, or perhaps DCHECKs or something.

Either one of these is better than having some somewhat random code added to the
startup functions; startup is so hairy we should go to great lengths to avoid
making it do anything further.

[Ivan Korotkov, 2012/12/21 09:59:48]

Ok, let's do the 1st option.

+#endif
+
   // In Aura builds this will initialize ash::Shell.
   ChromeBrowserMainPartsLinux::PreProfileInit();
 }
 
 void ChromeBrowserMainPartsChromeos::PostProfileInit() {
   // -- This used to be in ChromeBrowserMainParts::PreMainMessageLoopRun()
   // -- just after CreateProfile().
 
   policy::BrowserPolicyConnector* connector =
       g_browser_process->browser_policy_connector();
 
   if (parsed_command_line().HasSwitch(::switches::kLoginUser) &&
       !parsed_command_line().HasSwitch(::switches::kLoginPassword)) {
     // Pass the TokenService pointer to the policy connector so user policy can
     // grab a token and register with the policy server.
     // TODO(mnissler): Remove once OAuth is the only authentication mechanism.
     connector->SetUserPolicyTokenService(
         TokenServiceFactory::GetForProfile(profile()));
 
     // Make sure we flip every profile to not share proxies if the user hasn't
     // specified so explicitly.
     const PrefService::Preference* use_shared_proxies_pref =
         profile()->GetPrefs()->FindPreference(prefs::kUseSharedProxies);
     if (use_shared_proxies_pref->IsDefaultValue())
       profile()->GetPrefs()->SetBoolean(prefs::kUseSharedProxies, false);
+
+    // This is done in LoginUtils::OnProfileCreated during normal login.
+    LoginUtils::Get()->InitRlzDelayed(profile());
   }
 
   // Make sure the NetworkConfigurationUpdater is ready so that it pushes ONC
   // configuration before login.
   connector->GetNetworkConfigurationUpdater();
 
   // Make sure that wallpaper boot transition and other delays in OOBE
   // are disabled for tests by default.
   // Individual tests may enable them if they want.
   if (parsed_command_line().HasSwitch(::switches::kTestType))
@@ skipping 195 matching lines @@
     } else if (trial->group() == margin_200mb) {
       LOG(WARNING) << "low_mem: Part of '200MB' experiment";
       LowMemoryObserver::SetLowMemoryMargin(200);
     } else {
       LOG(WARNING) << "low_mem: Part of 'default' experiment";
     }
   }
 }
 
 }  //  namespace chromeos