Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 11503016: [MIPS] Minor fixes for service runtime. (Closed)

Created:
8 years ago by petarj
Modified:
8 years ago
Reviewers:
Mark Seaborn, bsy
CC:
native-client-reviews_googlegroups.com, bsy
Visibility:
Public.

Description

[MIPS] Minor fixes for service runtime. This change: - renames NaClAllocateSpace for MIPS to NaClAllocateSpaceAslr, and - defines symbol NaClSyscallThreadCaptureFault for MIPS. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= pnacl/build.sh misc-tools Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/trusted/service_runtime/arch/mips/nacl_syscall.S View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/arch/mips/sel_addrspace_mips.c View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
petarj
A recent CL that changes internal address space API broke the build for MIPS. Here ...
8 years ago (2012-12-10 18:54:00 UTC) #1
bsy
lgtm
8 years ago (2012-12-10 18:56:33 UTC) #2
Mark Seaborn
LGTM
8 years ago (2012-12-10 19:00:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/11503016/1
8 years ago (2012-12-10 20:02:55 UTC) #4
commit-bot: I haz the power
Try job failure for 11503016-1 (retry) on nacl-lucid_64-newlib-arm_qemu-pnacl for steps "annotate, scons [arm] [small_tests medium_tests] ...
8 years ago (2012-12-10 21:03:01 UTC) #5
petarj
On 2012/12/10 21:03:01, I haz the power (commit-bot) wrote: It seems there is at least ...
8 years ago (2012-12-10 21:45:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/11503016/1
8 years ago (2012-12-10 22:24:31 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-11 00:03:40 UTC) #8
Message was sent while issue was closed.
Change committed as 10427

Powered by Google App Engine
This is Rietveld 408576698